-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(extension): coverage for new stake pool sorting #1067
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allure report
smokeTests: ✅ test report for 73e6496a
|
Smoke tests are failing due to unstable env |
oldGreg5
requested changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on sorting bonanza ;)
packages/e2e-tests/src/features/MultiDelegationPageExtended.part1.feature
Outdated
Show resolved
Hide resolved
packages/e2e-tests/src/features/MultiDelegationPageExtended.part2.feature
Outdated
Show resolved
Hide resolved
packages/e2e-tests/src/features/MultiDelegationPageExtended.part2.feature
Outdated
Show resolved
Hide resolved
packages/e2e-tests/src/assert/multidelegation/MultidelegationPageAssert.ts
Show resolved
Hide resolved
packages/e2e-tests/src/assert/multidelegation/MultidelegationPageAssert.ts
Outdated
Show resolved
Hide resolved
packages/e2e-tests/src/elements/multidelegation/MultidelegationPage.ts
Outdated
Show resolved
Hide resolved
oldGreg5
approved these changes
Apr 16, 2024
Quality Gate passedIssues Measures |
wklos-iohk
added a commit
that referenced
this pull request
Apr 22, 2024
* test(extension): automate tests LW-10139 and LW-10141 * test(extension): speed up LW-8499 * test(extension): automate LW-10142 * test(extension): split feature file * test(extension): minor cleanup * test(extension): update after code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots
Attach screenshots here if implementation involves some UI changes