Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(extension): coverage for new stake pool sorting #1067

Merged
merged 8 commits into from
Apr 19, 2024

Conversation

wklos-iohk
Copy link
Contributor

@wklos-iohk wklos-iohk commented Apr 12, 2024

Checklist

  • JIRA - LW-10301
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.

Testing

Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met

Screenshots

Attach screenshots here if implementation involves some UI changes

Copy link

github-actions bot commented Apr 12, 2024

Allure report

allure-report-publisher generated test report!

smokeTests: ✅ test report for 73e6496a

passed failed skipped flaky total result
Total 27 0 0 0 27

@wklos-iohk wklos-iohk marked this pull request as ready for review April 15, 2024 13:26
@wklos-iohk wklos-iohk requested a review from a team as a code owner April 15, 2024 13:26
@wklos-iohk
Copy link
Contributor Author

Smoke tests are failing due to unstable env

Copy link
Contributor

@oldGreg5 oldGreg5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on sorting bonanza ;)

@wklos-iohk wklos-iohk requested a review from oldGreg5 April 16, 2024 10:09
Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@wklos-iohk wklos-iohk merged commit 6aa6964 into main Apr 19, 2024
9 checks passed
@wklos-iohk wklos-iohk deleted the test/coverage-for-new-stake-pool-sorting branch April 19, 2024 12:55
wklos-iohk added a commit that referenced this pull request Apr 22, 2024
* test(extension): automate tests LW-10139 and LW-10141

* test(extension): speed up LW-8499

* test(extension): automate LW-10142

* test(extension): split feature file

* test(extension): minor cleanup

* test(extension): update after code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants