fix(extension): fix infinite scroll on PopupView #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommayeliog
requested review from
VanessaPC,
mchappell,
vetalcore and
przemyslaw-wlodek
apps/browser-extension-wallet/src/components/Layout/MainLayout.module.scss
Show resolved
Hide resolved
Allure report
smokeTests: ✅ test report for b1ef9880
|
ljagiela
approved these changes
Apr 8, 2024
pczeglik-iohk
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Thank you @tommayeliog. Code approved and tested. Ready to be merged!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
I'm removing a CSS line, introduced by PR 833
The issue was that InfiniteScroll doesn't detect scroll event.
Testing
I'm not sure if this will break any other screen, so some regression testing is needed.
Screenshots