fix: [lw-11875] remove status info from reward activity details (#1577)

input-output-hk · Dec 6, 2024 · b3b1d06 · b3b1d06
1 parent 6f838b9
commit b3b1d06
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 36 deletions.
diff --git a/...r-extension-wallet/src/views/browser-view/features/activity/components/ActivityDetail.tsx b/...r-extension-wallet/src/views/browser-view/features/activity/components/ActivityDetail.tsx
@@ -136,7 +136,6 @@ export const ActivityDetail = ({ price }: ActivityDetailProps): ReactElement =>
     return (
       <RewardsDetails
         name={name}
-        status={activityInfo.status}
         includedDate={activityInfo.activity.includedUtcDate}
         includedTime={activityInfo.activity.includedUtcTime}
         amountTransformer={amountTransformer}

diff --git a/packages/core/src/ui/components/ActivityDetail/RewardsDetails.tsx b/packages/core/src/ui/components/ActivityDetail/RewardsDetails.tsx
@@ -2,7 +2,6 @@ import React from 'react';
 import cn from 'classnames';
 import { Tooltip } from 'antd';
 import styles from './TransactionDetails.module.scss';
-import { ActivityStatus } from '../Transaction';
 import { Ellipsis } from '@lace/common';
 import { ActivityDetailHeader } from './ActivityDetailHeader';
 import { useTranslation } from 'react-i18next';
@@ -21,7 +20,6 @@ export type RewardsInfo = {
 export interface RewardsDetailsProps {
   name: string;
   headerDescription?: string;
-  status: ActivityStatus.SPENDABLE;
   includedDate: string;
   includedTime: string;
   amountTransformer: (amount: string) => string;
@@ -32,7 +30,6 @@ export interface RewardsDetailsProps {
 export const RewardsDetails = ({
   name,
   headerDescription,
-  status,
   includedDate,
   includedTime,
   amountTransformer,
@@ -117,14 +114,6 @@ export const RewardsDetails = ({
             </div>
           )}
 
-          <div className={styles.details}>
-            <div className={styles.title} data-testid="rewards-status-title">
-              {t('core.activityDetails.status')}
-            </div>
-            <div data-testid="rewards-status" className={styles.detail}>{`${status
-              .charAt(0)
-              .toUpperCase()}${status.slice(1)}`}</div>
-          </div>
           <div className={styles.details}>
             <div className={styles.title} data-testid="rewards-epoch-title">
               {t('core.activityDetails.epoch')}

diff --git a/packages/core/src/ui/components/ActivityDetail/__tests__/RewardsDetails.test.tsx b/packages/core/src/ui/components/ActivityDetail/__tests__/RewardsDetails.test.tsx
@@ -3,13 +3,11 @@ import * as React from 'react';
 import { render } from '@testing-library/react';
 import '@testing-library/jest-dom';
 import { RewardsDetails, RewardsDetailsProps } from '../RewardsDetails';
-import { ActivityStatus } from '../../Transaction';
 
 describe('Testing ActivityDetailsBrowser component', () => {
   const rewardsDetailsProps: RewardsDetailsProps = {
     name: 'Name',
     headerDescription: 'Header Description',
-    status: ActivityStatus.SPENDABLE,
     includedDate: 'Date',
     includedTime: 'Time',
     amountTransformer: (amount) => `${amount} $`,

diff --git a/packages/e2e-tests/src/assert/transactionDetailsAssert.ts b/packages/e2e-tests/src/assert/transactionDetailsAssert.ts
@@ -431,18 +431,6 @@ class TransactionsDetailsAssert {
     await this.assertSeeRewardsStakePoolsSection();
     await this.assertSeeRewardsSinglePool();
 
-    await TransactionDetailsPage.transactionDetailsRewardsStatusTitle.waitForDisplayed();
-    expect(await TransactionDetailsPage.transactionDetailsRewardsStatusTitle.getText()).to.equal(
-      await t('core.activityDetails.status')
-    );
-    await TransactionDetailsPage.transactionDetailsRewardsStatus.waitForDisplayed();
-    expect(await TransactionDetailsPage.transactionDetailsRewardsStatus.getText()).to.be.oneOf([
-      'Spendable',
-      'Success',
-      'Sending',
-      'Error'
-    ]);
-
     await TransactionDetailsPage.transactionDetailsRewardsEpochTitle.waitForDisplayed();
     expect(await TransactionDetailsPage.transactionDetailsRewardsEpochTitle.getText()).to.equal(
       await t('core.activityDetails.epoch')

diff --git a/packages/e2e-tests/src/elements/transactionDetails.ts b/packages/e2e-tests/src/elements/transactionDetails.ts
@@ -58,8 +58,6 @@ class ActivityDetailsPage extends CommonDrawerElements {
   private TRANSACTION_DETAILS_REWARDS_POOL_ID = '[data-testid="rewards-pool-id"]';
   private TRANSACTION_DETAILS_REWARDS_SINGLE_POOL_ADA = '[data-testid="rewards-pool-reward-ada"]';
   private TRANSACTION_DETAILS_REWARDS_SINGLE_POOL_FIAT = '[data-testid="rewards-pool-reward-fiat"]';
-  private TRANSACTION_DETAILS_REWARDS_STATUS_TITLE = '[data-testid="rewards-status-title"]';
-  private TRANSACTION_DETAILS_REWARDS_STATUS = '[data-testid="rewards-status"]';
   private TRANSACTION_DETAILS_REWARDS_EPOCH_TITLE = '[data-testid="rewards-epoch-title"]';
   private TRANSACTION_DETAILS_REWARDS_EPOCH = '[data-testid="rewards-epoch"]';
   private TRANSACTION_DETAILS_REWARDS_TIMESTAMP_TITLE = '[data-testid="rewards-date-title"]';
@@ -305,14 +303,6 @@ class ActivityDetailsPage extends CommonDrawerElements {
     return $$(this.TRANSACTION_DETAILS_REWARDS_SINGLE_POOL_FIAT);
   }
 
-  get transactionDetailsRewardsStatusTitle(): ChainablePromiseElement<WebdriverIO.Element> {
-    return $(this.TRANSACTION_DETAILS_REWARDS_STATUS_TITLE);
-  }
-
-  get transactionDetailsRewardsStatus(): ChainablePromiseElement<WebdriverIO.Element> {
-    return $(this.TRANSACTION_DETAILS_REWARDS_STATUS);
-  }
-
   get transactionDetailsRewardsEpochTitle(): ChainablePromiseElement<WebdriverIO.Element> {
     return $(this.TRANSACTION_DETAILS_REWARDS_EPOCH_TITLE);
   }