fix(extension): resolve sdet comments

input-output-hk · Feb 27, 2024 · 38611ff · 38611ff
1 parent 3ebf507
commit 38611ff
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 9 deletions.
diff --git a/apps/browser-extension-wallet/src/lib/translations/en.json b/apps/browser-extension-wallet/src/lib/translations/en.json
@@ -1090,7 +1090,7 @@
           "title": "Cost",
           "tooltip": "The cost is not directly paid by the delegator; they are deducted from a pool's rewards, consisting of a fixed cost and a variable cost, which fund the pool's operational costs"
         },
-        "ros": {
+        "apy": {
           "title": "ROS",
           "tooltip": "An estimation of the potential rewards you will earn per epoch if you delegate the intended amount of stake. The system looks at the pool's parameters and historical performance data to calculate potential rewards, assuming that the pool reaches optimal saturation."
         },

diff --git a/...et/src/views/browser-view/features/staking/components/StakePoolsTable/StakePoolsTable.tsx b/...et/src/views/browser-view/features/staking/components/StakePoolsTable/StakePoolsTable.tsx
@@ -63,7 +63,7 @@ export const StakePoolsTable = ({ scrollableTargetId }: stakePoolsTableProps): R
 
   const tableHeaderTranslations: TranslationsFor<MetricType> = {
     ticker: t('cardano.stakePoolTableBrowser.tableHeader.ticker.title'),
-    apy: t('cardano.stakePoolTableBrowser.tableHeader.ros.title'),
+    apy: t('cardano.stakePoolTableBrowser.tableHeader.apy.title'),
     cost: t('cardano.stakePoolTableBrowser.tableHeader.cost.title'),
     saturation: t('cardano.stakePoolTableBrowser.tableHeader.saturation.title'),
     margin: t('cardano.stakePoolTableBrowser.tableHeader.margin.title'),
@@ -73,7 +73,7 @@ export const StakePoolsTable = ({ scrollableTargetId }: stakePoolsTableProps): R
   };
   const tableHeaderTooltipsTranslations: TranslationsFor<MetricType> = {
     ticker: t('cardano.stakePoolTableBrowser.tableHeader.ticker.tooltip'),
-    apy: t('cardano.stakePoolTableBrowser.tableHeader.ros.tooltip'),
+    apy: t('cardano.stakePoolTableBrowser.tableHeader.apy.tooltip'),
     cost: t('cardano.stakePoolTableBrowser.tableHeader.cost.tooltip'),
     saturation: t('cardano.stakePoolTableBrowser.tableHeader.saturation.tooltip'),
     margin: t('cardano.stakePoolTableBrowser.tableHeader.margin.tooltip'),

diff --git a/packages/staking/src/features/BrowsePools/BrowsePools.tsx b/packages/staking/src/features/BrowsePools/BrowsePools.tsx
@@ -54,7 +54,7 @@ export const BrowsePools = () => {
   const fetchingPools = walletStoreStakePoolSearchResultsStatus === StateStatus.LOADING;
 
   const tableHeaderTranslations = {
-    apy: t('browsePools.stakePoolTableBrowser.tableHeader.ros.title'),
+    apy: t('browsePools.stakePoolTableBrowser.tableHeader.apy.title'),
     blocks: t('browsePools.stakePoolTableBrowser.tableHeader.blocks.title'),
     cost: t('browsePools.stakePoolTableBrowser.tableHeader.cost.title'),
     liveStake: t('browsePools.stakePoolTableBrowser.tableHeader.liveStake.title'),

diff --git a/packages/staking/src/features/DelegationCard/DelegationTooltip.tsx b/packages/staking/src/features/DelegationCard/DelegationTooltip.tsx
@@ -19,7 +19,7 @@ export const DelegationTooltip = ({
         description={
           <Box w="$148">
             <Flex justifyContent="space-between">
-              <Box>{t('browsePools.stakePoolTableBrowser.tableHeader.ros.title')}</Box>
+              <Box>{t('browsePools.stakePoolTableBrowser.tableHeader.apy.title')}</Box>
               <Box>{apy ? `${apy}%` : '-'}</Box>
             </Flex>
             <Flex justifyContent="space-between">

diff --git a/packages/staking/src/features/i18n/translations/en.ts b/packages/staking/src/features/i18n/translations/en.ts
@@ -35,6 +35,9 @@ export const en: Translations = {
   'browsePools.stakePoolTableBrowser.sortByTitle.saturation': 'Saturation',
   'browsePools.stakePoolTableBrowser.sortByTitle.ticker': 'Ticker name',
   'browsePools.stakePoolTableBrowser.stake': 'Stake',
+  'browsePools.stakePoolTableBrowser.tableHeader.apy.title': 'ROS',
+  'browsePools.stakePoolTableBrowser.tableHeader.apy.tooltip':
+    "An estimation of the potential rewards you will earn per epoch if you delegate the intended amount of stake. The system looks at the pool's parameters and historical performance data to calculate potential rewards, assuming that the pool reaches optimal saturation.",
   'browsePools.stakePoolTableBrowser.tableHeader.blocks.title': 'Blocks',
   'browsePools.stakePoolTableBrowser.tableHeader.blocks.tooltip': 'Total blocks created by the pool.',
   'browsePools.stakePoolTableBrowser.tableHeader.cost.title': 'Cost',
@@ -49,9 +52,6 @@ export const en: Translations = {
   'browsePools.stakePoolTableBrowser.tableHeader.pledge.title': 'Pledge',
   'browsePools.stakePoolTableBrowser.tableHeader.pledge.tooltip':
     'An amount of self‐bonded assets intended to remain staked to the pool for as long as it operates',
-  'browsePools.stakePoolTableBrowser.tableHeader.ros.title': 'ROS',
-  'browsePools.stakePoolTableBrowser.tableHeader.ros.tooltip':
-    "An estimation of the potential rewards you will earn per epoch if you delegate the intended amount of stake. The system looks at the pool's parameters and historical performance data to calculate potential rewards, assuming that the pool reaches optimal saturation.",
   'browsePools.stakePoolTableBrowser.tableHeader.saturation.title': 'Saturation',
   'browsePools.stakePoolTableBrowser.tableHeader.saturation.tooltip':
     'Once a pool reaches the point of saturation, it will offer diminishing rewards',

diff --git a/packages/staking/src/features/i18n/types.ts b/packages/staking/src/features/i18n/types.ts
@@ -72,7 +72,7 @@ type KeysStructure = {
           title: '';
           tooltip: '';
         };
-        ros: {
+        apy: {
           title: '';
           tooltip: '';
         };