Merge branch 'main' into fix/lw-9912-fix-old-firmware-multidelegation…

…-defect

.github/workflows/build-dev-preview.yml

@@ -22,11 +22,11 @@ jobs:
           PRODUCTION_MODE_TRACKING: 'false'
       - name: Check for linter issues
         run: yarn lint
-      - name: Run unit tests, generate test coverage report
+      - name: Run unit tests
         env:
           AVAILABLE_CHAINS: 'Preprod,Preview,Mainnet'
           DEFAULT_CHAIN: 'Preprod'
-        run: yarn test:coverage --maxWorkers=2 --silent
+        run: yarn test --maxWorkers=2 --silent
       - name: Upload build
         uses: actions/upload-artifact@v4
         with:

.github/workflows/ci.yml

@@ -28,20 +28,14 @@ jobs:
           PRODUCTION_MODE_TRACKING: ${{ startsWith(github.ref, 'refs/heads/release') && 'true' || 'false' }}
       - name: Check for linter issues
         run: yarn lint
-      - name: Run unit tests, generate test coverage report
+      - name: Run unit tests
         env:
           AVAILABLE_CHAINS: 'Preprod,Preview,Mainnet'
           DEFAULT_CHAIN: 'Preprod'
           NODE_OPTIONS: '--max_old_space_size=8192'
-        run: yarn test:coverage --maxWorkers=2 --silent
+        run: yarn test --maxWorkers=2 --silent
       - name: Upload build
         uses: actions/upload-artifact@v4
         with:
           name: lace
           path: apps/browser-extension-wallet/dist
-      - name: Upload Coveralls report
-        uses: coverallsapp/github-action@v2
-        with:
-          github-token: ${{ secrets.COVERALLS_REPO_TOKEN  }}
-          allow-empty: true
-          compare-ref: main

.github/workflows/core-chromatic.yml

@@ -2,6 +2,7 @@ name: Lace Core Chromatic
 
 on:
   pull_request:
+    types: [opened, synchronize, reopened, ready_for_review]
     paths:
       - packages/core/**
   push:
@@ -12,6 +13,7 @@ on:
 
 jobs:
   chromatic-deployment:
+    if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository

.github/workflows/git-checks.yml

@@ -1,9 +1,12 @@
 name: Git Checks
 
-on: [pull_request]
+on:
+  pull_request:
+    types: [opened, synchronize, reopened, ready_for_review]
 
 jobs:
   block-fixup:
+    if: github.event.pull_request.draft == false
     runs-on: ubuntu-20.04
 
     steps:

.github/workflows/packages-staking.yml

@@ -43,12 +43,7 @@ jobs:
       - name: Build dependencies of Staking Center
         run: yarn staking build-deps
       - name: Run tests
-        run: yarn workspace @lace/staking test:unit --coverage
-      - name: Upload test coverage artifacts
-        uses: actions/upload-artifact@v4
-        with:
-          name: staking-coverage
-          path: packages/staking/coverage
+        run: yarn workspace @lace/staking test:unit
       - name: Build Staking dist
         run: yarn workspace @lace/staking build
 #        TODO fix ladle build

.github/workflows/post-integration.yml

@@ -20,10 +20,9 @@ jobs:
         with:
           name: lightwallet
           path: apps/browser-extension-wallet/dist
-      - name: Run unit tests, generate test coverage report
-        run: yarn test:coverage --maxWorkers=2 --silent
-      - name: Upload Coveralls report
-        uses: coverallsapp/github-action@v2
-        with:
-          github-token: ${{ secrets.COVERALLS_REPO_TOKEN  }}
-          allow-empty: true
+      - name: Run unit tests
+        env:
+          AVAILABLE_CHAINS: 'Preprod,Preview,Mainnet'
+          DEFAULT_CHAIN: 'Preprod'
+          NODE_OPTIONS: '--max_old_space_size=8192'
+        run: yarn test --maxWorkers=2 --silent

.github/workflows/sonar-cloud.yml

@@ -0,0 +1,21 @@
+name: SonarCloud
+on:
+  push:
+    branches:
+      - main
+      - release/**
+  pull_request:
+    types: [opened, synchronize, reopened]
+jobs:
+  sonarcloud:
+    name: SonarCloud Code Analysis
+    runs-on: ubuntu-22.04
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
+      - name: SonarCloud Scan
+        uses: SonarSource/sonarcloud-github-action@master
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}  # Needed to get PR information, if any
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

.github/workflows/staking-chromatic.yml

@@ -2,6 +2,7 @@ name: Lace Staking Chromatic
 
 on:
   pull_request:
+    types: [opened, synchronize, reopened, ready_for_review]
     paths:
       - packages/staking/**
   push:
@@ -12,6 +13,7 @@ on:
 
 jobs:
   chromatic-deployment:
+    if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository

.github/workflows/ui-toolkit-chromatic.yml

@@ -2,6 +2,7 @@ name: Lace UI Toolkit
 
 on:
   pull_request:
+    types: [opened, synchronize, reopened, ready_for_review]
     paths:
       - packages/ui/**
   push:
@@ -12,6 +13,7 @@ on:
 
 jobs:
   chromatic-deployment:
+    if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository

apps/browser-extension-wallet/.env.defaults

@@ -25,7 +25,7 @@ USE_POSTHOG_ANALYTICS=true
 USE_MULTI_DELEGATION_STAKING_LEDGER=false
 USE_MULTI_DELEGATION_STAKING_TREZOR=false
 USE_MULTI_DELEGATION_STAKING_ACTIVITY=true
-USE_MULTI_DELEGATION_STAKING_GRID_VIEW=false
+USE_MULTI_DELEGATION_STAKING_GRID_VIEW=true
 USE_MULTI_DELEGATION_STAKING_FILTERS=false
 USE_ROS_STAKING_COLUMN=false
 
@@ -38,7 +38,6 @@ CATALYST_GOOGLE_PLAY_URL=https://play.google.com/store/apps/details?id=io.iohk.v
 CATALYST_APP_STORE_URL=https://apps.apple.com/fr/app/catalyst-voting/id1517473397?l=en
 TWITTER_URL=https://twitter.com/lace_io
 YOUTUBE_URL=https://www.youtube.com/c/Laceio
-MEDIUM_URL=https://medium.com/@lace_wallet
 GITHUB_URL=https://github.com/input-output-hk
 DISCORD_URL=https://discord.gg/lacewallet
 WEBSITE_URL=https://www.lace.io

apps/browser-extension-wallet/.env.developerpreview

@@ -26,7 +26,7 @@ USE_POSTHOG_ANALYTICS=true
 USE_MULTI_DELEGATION_STAKING_LEDGER=false
 USE_MULTI_DELEGATION_STAKING_TREZOR=false
 USE_MULTI_DELEGATION_STAKING_ACTIVITY=true
-USE_MULTI_DELEGATION_STAKING_GRID_VIEW=false
+USE_MULTI_DELEGATION_STAKING_GRID_VIEW=true
 USE_ROS_STAKING_COLUMN=false
 
 USE_POSTHOG_ANALYTICS_FOR_OPTED_OUT=false
@@ -38,7 +38,6 @@ CATALYST_GOOGLE_PLAY_URL=https://play.google.com/store/apps/details?id=io.iohk.v
 CATALYST_APP_STORE_URL=https://apps.apple.com/fr/app/catalyst-voting/id1517473397?l=en
 TWITTER_URL=https://twitter.com/lace_io
 YOUTUBE_URL=https://www.youtube.com/c/Laceio
-MEDIUM_URL=https://medium.com/@lace_wallet
 GITHUB_URL=https://github.com/input-output-hk
 DISCORD_URL=https://discord.gg/lacewallet
 WEBSITE_URL=https://www.lace.io

apps/browser-extension-wallet/.env.example

@@ -25,7 +25,7 @@ USE_DATA_CHECK=false
 USE_POSTHOG_ANALYTICS=true
 USE_POSTHOG_ANALYTICS_FOR_OPTED_OUT=false
 USE_MULTI_DELEGATION_STAKING_ACTIVITY=true
-USE_MULTI_DELEGATION_STAKING_GRID_VIEW=false
+USE_MULTI_DELEGATION_STAKING_GRID_VIEW=true
 USE_MULTI_DELEGATION_STAKING_FILTERS=false
 USE_ROS_STAKING_COLUMN=false
 
@@ -34,7 +34,6 @@ CATALYST_GOOGLE_PLAY_URL=https://play.google.com/store/apps/details?id=io.iohk.v
 CATALYST_APP_STORE_URL=https://apps.apple.com/fr/app/catalyst-voting/id1517473397?l=en
 TWITTER_URL=https://twitter.com/lace_io
 YOUTUBE_URL=https://www.youtube.com/c/Laceio
-MEDIUM_URL=https://medium.com/@lace_wallet
 GITHUB_URL=https://github.com/input-output-hk
 DISCORD_URL=https://discord.gg/inputoutput
 WEBSITE_URL=https://www.lace.io

apps/browser-extension-wallet/manifest.json

@@ -1,7 +1,7 @@
 {
   "name": "$WALLET_MANIFEST_NAME",
   "description": "One fast, accessible, and secure platform for digital assets, DApps, NFTs, and DeFi.",
-  "version": "1.9.0",
+  "version": "1.10.1",
   "manifest_version": 3,
   "key": "$LACE_EXTENSION_KEY",
   "icons": {

apps/browser-extension-wallet/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lace/browser-extension-wallet",
-  "version": "1.9.0",
+  "version": "1.10.1",
   "description": "A fully capable wallet packaged as browser extensions for Chrome, Firefox, and Edge",
   "homepage": "https://github.com/input-output-hk/lace/blob/master/apps/browser-extension-wallet/README.md",
   "bugs": {
@@ -34,7 +34,6 @@
     "prepare": "ts-patch install -s",
     "prettier": "run -T prettier --write .",
     "test": "run -T jest --config test/jest.config.js",
-    "test:coverage": "NODE_OPTIONS=\"--max-old-space-size=8192\" run -T test --coverage --silent",
     "test:e2e": "yarn exec echo \"No e2e tests on this app yet!\"",
     "watch": "NODE_OPTIONS='--openssl-legacy-provider' rm -rf dist & run -T webpack --config webpack.sw.dev.js --progress --watch & run -T webpack --config webpack.app.dev.js --progress --watch"
   },
@@ -43,11 +42,11 @@
     "@cardano-sdk/cardano-services-client": "0.18.0",
     "@cardano-sdk/core": "0.30.0",
     "@cardano-sdk/dapp-connector": "0.12.14",
-    "@cardano-sdk/input-selection": "0.12.25",
-    "@cardano-sdk/tx-construction": "0.18.1",
+    "@cardano-sdk/input-selection": "0.12.26",
+    "@cardano-sdk/tx-construction": "0.18.2",
     "@cardano-sdk/util": "0.15.0",
-    "@cardano-sdk/wallet": "0.35.1",
-    "@cardano-sdk/web-extension": "0.26.0",
+    "@cardano-sdk/wallet": "0.35.2",
+    "@cardano-sdk/web-extension": "0.26.1",
     "@emurgo/cip14-js": "~3.0.1",
     "@koralabs/handles-public-api-interfaces": "^1.6.6",
     "@lace/cardano": "0.1.0",
@@ -70,7 +69,7 @@
     "dexie": "3.2.0-rc.2",
     "dexie-react-hooks": "1.0.7",
     "graphql-tag": "2.12.5",
-    "i18next": "20.4.0",
+    "i18next": "^22.5.1",
     "intersection-observer-polyfill": "0.1.0",
     "lodash": "4.17.21",
     "node-abort-controller": "^3.1.1",
@@ -80,7 +79,7 @@
     "process": "^0.11.10",
     "react": "17.0.2",
     "react-dom": "17.0.2",
-    "react-i18next": "11.11.4",
+    "react-i18next": "^12.3.1",
     "react-lottie": "^1.2.3",
     "react-router": "5.2.0",
     "react-router-dom": "5.2.0",

apps/browser-extension-wallet/src/components/Layout/MainLayout.module.scss

@@ -21,7 +21,6 @@
       display: flex;
       min-height: 0;
       width: 100%;
-      flex-direction: column;
       > * {
         width: 100%;
       }

apps/browser-extension-wallet/src/components/MainMenu/DropdownMenuOverlay/components/ThemeSwitcher.tsx

@@ -9,6 +9,7 @@ import MoonIcon from '../../../../assets/icons/moon.component.svg';
 import { useBackgroundServiceAPIContext } from '@providers/BackgroundServiceAPI';
 import { themes, useAnalyticsContext } from '@providers';
 import { PostHogAction } from '@providers/AnalyticsProvider/analyticsTracker';
+import { TranslationKey } from '@lib/translations/types';
 
 type ThemeAnalyticsEvents<T> = Record<themes, T>;
 
@@ -26,7 +27,7 @@ const userWalletProfileThemeEvent: ThemeAnalyticsEvents<
   light: PostHogAction.UserWalletProfileLightModeClick
 };
 
-const modeTranslate: Record<string, string> = {
+const modeTranslate: Record<string, TranslationKey> = {
   light: 'browserView.sideMenu.mode.light',
   dark: 'browserView.sideMenu.mode.dark'
 };

apps/browser-extension-wallet/src/components/WalletStatus/WalletStatusContainer.tsx

@@ -2,8 +2,9 @@ import React, { useState, useEffect } from 'react';
 import { useTranslation } from 'react-i18next';
 import { useSyncStatus } from '@src/stores';
 import { WalletStatus, Status } from './WalletStatus';
+import { TranslationKey } from '@lib/translations/types';
 
-const DEFAULT_WALLET_STATUS = {
+const DEFAULT_WALLET_STATUS: { status: Status; text: TranslationKey } = {
   status: Status.SYNCING,
   text: 'browserView.topNavigationBar.walletStatus.walletSyncing'
 };

apps/browser-extension-wallet/src/features/address-book/components/AddressDetailDrawer/types/index.ts

@@ -1,3 +1,5 @@
+import { TranslationKey } from '@lib/translations/types';
+
 export enum AddressDetailsSteps {
   DETAILS,
   CREATE,
@@ -8,8 +10,8 @@ export interface AddressDetailsSectionConfig {
   currentSection: AddressDetailsSteps;
   nextSection?: AddressDetailsSteps;
   prevSection?: AddressDetailsSteps;
-  headerTitle?: string;
-  headerSubtitle?: string;
+  headerTitle?: TranslationKey;
+  headerSubtitle?: TranslationKey;
 }
 
 export type AddressDetailsConfig = Partial<Record<AddressDetailsSteps, AddressDetailsSectionConfig>>;

apps/browser-extension-wallet/src/features/dapp/components/confirm-transaction/ConfirmTransaction.module.scss

@@ -6,7 +6,7 @@
   padding-top: size_unit(0);
 }
 
-.transactionContainer { 
+.transactionContainer {
   display: flex;
   flex-direction: column;
   flex: 1;
@@ -15,13 +15,13 @@
 
 .actions {
   @extend %flex-column;
-  height: size_unit(17.12);
   justify-content: space-between;
-  padding: size_unit(2) size_unit(3) size_unit(2) size_unit(3);
+  padding: size_unit(3) 0;
   border-top: 1px solid var(--light-mode-light-grey-plus, var(--dark-mode-mid-grey));
   position: sticky;
   bottom: 0;
   z-index: 10;
+  gap: size_unit(1);
   background-color: var(--light-mode-body, var(--dark-mode-bg-black));
   .actionBtn {
     width: 100%;