Re-enable QSM tests for all distributions #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
approved these changes
Nov 30, 2023
auto-merge was automatically disabled
February 12, 2024 19:23
Merge queue setting changed
jorisdral
force-pushed
the
jdral/enable-qsm-tests
branch
from
9f0150c to
8aaf986
Compare
jorisdral
force-pushed
the
jdral/enable-qsm-tests
branch
5 times, most recently
from
c9ad979 to
0a8cff4
Compare
jorisdral
force-pushed
the
jdral/enable-qsm-tests
branch
from
0a8cff4 to
572a7d2
Compare
As a "temporary" fix for fs-sim#45, we make the implementation of `sameError` more lenient on MacOS systems. This will possibly be revisited in the future, but for now it should enable running the `q-s-m` tests on all distributions again.
jorisdral
force-pushed
the
jdral/enable-qsm-tests
branch
from
572a7d2 to
b1ff8af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a "temporary" fix for fs-sim#45, we make the implementation of
sameErrormore lenient on MacOS systems. This will possiblybe revisited in the future, but for now it should enable running
the
q-s-mtests on all distributions again.