Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stack View Animation #4799

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: Stack View Animation #4799

wants to merge 7 commits into from

Conversation

Resaki1
Copy link
Collaborator

@Resaki1 Resaki1 commented Jan 22, 2025

Description

Due to changes in the stack view layout, the animation that appears when navigating between notes was a little broken. This has been fixed. Includes minor code improvements.

Changelog

There were three issues with the animation:

  1. The width of the container was limited with overflow: hidden, meaning the notes were cut off left and right during the animation.
  2. When navigating between stacks with a different number of stacked notes, the height of the container would change instantly at the start of the animation, cutting the notes off at the bottom.
  3. When navigating between columns, the previous stack would instantly disappear.

These issues have been fixed, as shown below:

Visual Changes

Before

Bildschirmaufnahme.2025-01-22.um.16.06.37.mov

After

Bildschirmaufnahme.2025-01-22.um.16.05.45.mov

This comment has been minimized.

Copy link
Collaborator

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throws an error in Firefox 134.0.2 when trying to transition between columns:

Firefox column transition error

@Schwehn42 Schwehn42 added the Changes Requested Changes requested by the reviewer label Jan 23, 2025
@Resaki1
Copy link
Collaborator Author

Resaki1 commented Jan 23, 2025

throws an error in Firefox 134.0.2 when trying to transition between columns:

Firefox column transition error

Oops, I forgot that Firefox does not support the View Transition API. Should be fixed now, thanks

This comment has been minimized.

Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4799.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-d2b401e

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-d2b401e

Copy link

octomind-dev bot commented Jan 23, 2025

🐙 Octomind

Test Report: 14/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: d2b401e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Requested Changes requested by the reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants