Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

servershell: Add column helper buttons #380

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

seqizz
Copy link
Contributor

@seqizz seqizz commented Dec 3, 2024

Adds 2 small buttons next to each column which triggers orderby/attr commands to sort by/remove columns respectively.

Preview:
image

  • It uses fontawesome (free) 6.7.1 for the icons, which might be questionable but this is the best I know
  • My JS skills are sub-zero, so feel free to suggest better handling if I missed something

@seqizz seqizz requested a review from kofrezo December 3, 2024 20:40
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the webfonts directory to the setup.py so it is included in the package:

servershell.commands.attr(attribute);
}),
// Add 1 space after minus icon to visually separate the columns
$('<span>').html('&nbsp;')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is preferably done via CSS (margin right).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants