Add extra memory reservation for in-use ceph disks #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamaral
approved these changes
Dec 18, 2024
kofrezo
reviewed
Dec 18, 2024
| """ | ||
| total_reserved_mib = HOST_RESERVED_MEMORY_MIB[self.get_storage_type()] | ||
| # ceph_disks is a multi-attribute holding one record for each OSD | ||
| # and their size. For each, we'll reserve 4GiB of memory. |
There was a problem hiding this comment.
I love that you explain the reasoning. ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small addition which uses new SA attribute
Ref: BOP-48763