Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Collect UMA stats #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Draft: Collect UMA stats #185

wants to merge 1 commit into from

Conversation

TuxPowered42
Copy link
Contributor

No description provided.

@TuxPowered42 TuxPowered42 requested a review from lamaral February 13, 2024 17:22
Comment on lines +63 to +64
for line in sysctl.filter(f'vm.uma.{oid}.{metric}'):
uma_info[oid][metric] = parse_sysctl_value(line)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need this for loop?
The left side of the assignment doesn't change with the for, so you either have a single element or you are overwriting data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants