Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include unit of returned value #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Include unit of returned value #127

wants to merge 1 commit into from

Conversation

TuxPowered42
Copy link
Contributor

No description provided.

TheFRedFox
TheFRedFox approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@TheFRedFox TheFRedFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is surely correct. ^^

Just semantic question: What made it important now to change it to explicitly KiB?

@TuxPowered42 TuxPowered42 force-pushed the libvirt_units branch 3 times, most recently from 8daf7b2 to ef97af6 Compare August 12, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheFRedFox TheFRedFox TheFRedFox approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TuxPowered42 @TheFRedFox