Issue/6007 e2e removal #6069
Closed
Issue/6007 e2e removal #6069
+179
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasStordeur
requested changes
Nov 26, 2024
| cy.get('[aria-label="Environment card"]') | ||
| .contains("lsm-frontend") | ||
| .click(); | ||
| cy.get(".pf-v5-c-nav__item").contains("Service Catalog").click(); |
There was a problem hiding this comment.
If we can avoid using the class, that would be great :)
LukasStordeur
approved these changes
Nov 26, 2024
|
Processing this pull request |
|
Merged into branches master in 22d0e0a |
inmantaci
pushed a commit
that referenced
this pull request
Nov 26, 2024
… PR #6069) # Description Added e2e for inter-service relations, fixed issue with removing inter-service relations for instance that could have an array of those, added constraint to deploy button, fixed issue with relation removal didn't trigger the update of the cell closes #6007 # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [ ] Attached issue to pull request - [ ] Changelog entry - [ ] Code is clear and sufficiently documented - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added e2e for inter-service relations, fixed issue with removing inter-service relations for instance that could have an array of those, added constraint to deploy button, fixed issue with relation removal didn't trigger the update of the cell
closes #6007
Self Check:
Strike through any lines that are not applicable (
~~line~~) then check the box