Issue/executor log cleanup #8000
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlloreda
reviewed
Aug 23, 2024
| @@ -245,7 +245,7 @@ async def get(self, member_id: TPoolID) -> TPoolMember: | |||
| """ | |||
| Returns a valid pool member for the given id | |||
| """ | |||
| LOGGER.debug("%s: requesting %s", self.my_name(), self.render_id(member_id)) | |||
| LOGGER.log(LOG_LEVEL_TRACE, "%s: requesting %s", self.my_name(), self.render_id(member_id)) | |||
There was a problem hiding this comment.
What is the difference between this log level trace and the debug level? I'm unsure to see when to use one over the other.
There was a problem hiding this comment.
Trace is one level lower than debug.
The reason I reduced this that for every call to an executor (and they happen A LOT),
- for a cache hit we get two log lines at debug level, extremely close together. (requesting and found)
- for a cache miss we also get 2 (requested and creating) but not one when it is done creating.
So this log line is at trace, in order to debug locking issues, which should be extremely rare.
hlloreda
approved these changes
Aug 23, 2024
|
Processing this pull request |
|
Merged into branches master in ce4de1a |
inmantaci
pushed a commit
that referenced
this pull request
Aug 23, 2024
# Description Final log cleanup, based on working with systemtenant closes #7692 # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [x] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Final log cleanup, based on working with systemtenant
closes #7692
Self Check:
Strike through any lines that are not applicable (
~~line~~) then check the box