Add ability to update worker name #7746
Conversation
| @@ -165,6 +166,9 @@ async def test_executor_server_dirty_shutdown(mpmanager: MPManager, caplog): | |||
| assert ["aaaa"] == result | |||
| print("Child there") | |||
|
|
|||
| process_name = psutil.Process(pid=child1.process.pid).name() | |||
| assert process_name == "inmanta: executor test - connected" | |||
There was a problem hiding this comment.
I wondering whether we should include the full identity of an executor here, because multiple agents with the same name can exist at the same time. For example when a dry-run is requested for an unreleased version. With this implementation it will be hard to keep them apart.
There was a problem hiding this comment.
I agree (see description), I just don't see how to make this identity meaningful...
There was a problem hiding this comment.
We could make it the concatenation of all known model versions (with a limit), collapsed into ranges? e.g. v1-10,12-20.
Not pretty, but the best I can think of atm.
There was a problem hiding this comment.
it is volatile and not part of the current interfaces, but I kind of like it.
The ranges may compact quite badly, because not every version may reach the executor so it will not be aware of everything.
I don't think I'm going to add it now, but it is something to keep in mind
There was a problem hiding this comment.
moved remark to #7692
|
Processing this pull request |
|
Merged into branches master in d51ede4 |
# Description I added the ability to update the name of the process, to make debugging easier 1. It now identifies the agent, not the code version or anything 2. it shows the status (connecting/connected/disconnected) 2. I could take it further and show every action (deploying resource x_y_z) 3. this requires an additional dependency, which I don't like, but I see no alternative # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [ ] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
Description
I added the ability to update the name of the process, to make debugging easier
Self Check:
Strike through any lines that are not applicable (
~~line~~) then check the box