Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version tests to use Ansible 2.5+ syntax #69

Merged
merged 1 commit into from
May 8, 2020
Merged

Update version tests to use Ansible 2.5+ syntax #69

merged 1 commit into from
May 8, 2020

Conversation

dudefellah
Copy link
Contributor

This pull request is meant to address the small whitespace problem from #63 so it should equally address #42 and #62.

I did notice that there was another instance of version_compare used in the wildfly_init_src_path template string from defaults/main.yml so I added a fix to that in here as well.

Additionally, by replacing the use of version_compare with is version, Ansible versions 2.2-2.4 would no longer be supported, so I changed the minimum version in meta/main.yml to 2.5. Finally, the pre-commit linting process complained about switching categories to galaxy_tags in the meta/main.yml file as well, so I made that change.

@inkatze inkatze merged commit 7735623 into inkatze:master May 8, 2020
@inkatze
Copy link
Owner

inkatze commented May 8, 2020

Thanks, y'all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants