-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Self hosting bundles #61
base: patchwork
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for tee-production ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
14ad87b
to
a86e13d
Compare
This needs a bit more work:
One way to scope cut here is to keep the lazy loading of the modules and remove the dynamic loading for now. |
Very nice progress!
I wonder if we want to allow a single module to export both a datatype and a tool. (Or more generally, any number of datatypes / tools?) In practice it seems like a common pattern to define a tool and datatype together, so we should make sure that's not overly annoying to do...
I saw the single centralized ID namespace as a crutch anyway -- what if we just use URLs as the unique identifiers, and then have separate human readable names?
Curious to hear more about what the limitations are here and how fixable we think they are...
Curious if lazy loading on its own would get us any tangible benefits? Maybe would be better to just keep pushing on dynamic loading if the end goal is loading from automerge docs? BTW, this might be further down the road I'm curious if you've thought about how we'll eventually handle modules that are updated while they're being run -- I'd assume currently you'd need to do a page reload to get new module code? |
This is a first step towards self-hosted patchwork
https://www.loom.com/share/1bf46c7239d14ef88fc99784d71fb230
Todo