Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip dce when feed is constant #50

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Skip dce when feed is constant #50

merged 4 commits into from
Nov 25, 2024

Conversation

inisis
Copy link
Owner

@inisis inisis commented Nov 25, 2024

Closes #49

When node is feed with constant, we should not delete them manually, but with constant folding.
image

@inisis inisis changed the title skip cast dce in subgraph Skip dce then feed is constant Nov 25, 2024
@inisis inisis self-assigned this Nov 25, 2024
@inisis inisis changed the title Skip dce then feed is constant Skip dce when feed is constant Nov 25, 2024
@inisis inisis merged commit 8e0105e into main Nov 25, 2024
5 checks passed
@inisis inisis deleted the dev branch November 25, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when trying to slim Qwen2VL vision encoder: ValueError: list.remove(x): x not in list
2 participants