Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup money #3535

Merged
merged 60 commits into from
Oct 2, 2024
Merged

cleanup money #3535

merged 60 commits into from
Oct 2, 2024

Commits on Jul 31, 2024

  1. restructures ResultType and decouples printing into ResultPrinters:

    - ResultType is now very simple mix of primitive enum and LIST. (We hope to remove even more logic from it)
    - Result printing was always weird with Mappings embedded in StringT. We've moved that responsibility into ResultInfo via SelectResultInfo for mapped Selects.
    - This PR opens the possibility to embed anonymization into the ResultInfo.
    - PrintSettings now caches the C10n calls as they were before that sometimes invoked per cell, which should make rendering faster.
    awildturtok committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    e688d98 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    84ad761 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. fix Printer signature

    awildturtok committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    18a0bd8 View commit details
    Browse the repository at this point in the history
  2. minor cleanup of naming

    awildturtok committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    061c9ac View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    92ba8d0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bab8bab View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a3a0a42 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Configuration menu
    Copy the full SHA
    56950fd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7645cf1 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Configuration menu
    Copy the full SHA
    f152160 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d2a9986 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    31de3f2 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Configuration menu
    Copy the full SHA
    8b2ee30 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0eecef6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cb0c47e View commit details
    Browse the repository at this point in the history
  4. cleanup superfluous c'tor

    awildturtok committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    3bd7407 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d4692bf View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Configuration menu
    Copy the full SHA
    e95bb29 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6d03233 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d8cceb5 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. reworks Money to no longer be "cent" based and instead just use it as…

    … storage primitive. Is now BigDecimal
    awildturtok committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    15237c9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f6ff223 View commit details
    Browse the repository at this point in the history
  3. Reworks Printers:

    We inject the result specific Printers using the printerFactory. This untangles the burden of formatting.
    
    Now a Select claiming to produce a specific type only needs to guarantee they are in a format capable of being handled by the printers it elects to use.
    
    This allows us later to make a printer that alters the result before printing it, without having to inject into all renderers.
    awildturtok committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    7d53595 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    39608be View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3a3f81c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a39c4f4 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d92b0a9 View commit details
    Browse the repository at this point in the history
  8. cleanup ResultTestUtil

    awildturtok committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    4fdb5c2 View commit details
    Browse the repository at this point in the history
  9. adds missing Dataset

    awildturtok committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    84549da View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    ab633f9 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    a769b16 View commit details
    Browse the repository at this point in the history
  12. delay binding of PrintSettings to createPrinter. Remove PrintSettings…

    … from ResultInfo, move all usages to usage sites.
    awildturtok committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    ce5f407 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    b97fc49 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    bbf9cb7 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    e95f8f7 View commit details
    Browse the repository at this point in the history
  16. fix handling of Money in ArrowResultGenerationTest separately to Parq…

    …uetResultGenerationTest
    awildturtok committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    4239f39 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Configuration menu
    Copy the full SHA
    8e9ed1e View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. 1 Configuration menu
    Copy the full SHA
    e0904a8 View commit details
    Browse the repository at this point in the history
  2. fix ResultTypeTest

    thoniTUB committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    88ce4fb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b939bef View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ca94db8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a82a528 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d5ae999 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9ee0f68 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b90891a View commit details
    Browse the repository at this point in the history
  9. removes deleted Select

    awildturtok committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    23a6b14 View commit details
    Browse the repository at this point in the history
  10. Code Style issues

    awildturtok committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    38e7833 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Configuration menu
    Copy the full SHA
    03434fb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    672cb42 View commit details
    Browse the repository at this point in the history
  3. semantics are immutable

    awildturtok committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f8ffea9 View commit details
    Browse the repository at this point in the history
  4. fixes missing null-Check

    awildturtok committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    8bdfdd1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6358f64 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Revert "try fixing Money handling for preview"

    This reverts commit 6358f64.
    awildturtok committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    65e701c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e9203fa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    88224e5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    efa20ba View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. fixes rescaling for Money

    awildturtok committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    c65d0fe View commit details
    Browse the repository at this point in the history
  2. simplify printer usage

    awildturtok committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    484acf2 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Configuration menu
    Copy the full SHA
    32d30d1 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Merge branch 'develop' into feature/cleanup-MONEY

    # Conflicts:
    #	backend/src/main/java/com/bakdata/conquery/models/query/SingleTableResult.java
    #	backend/src/main/java/com/bakdata/conquery/models/query/preview/EntityPreviewExecution.java
    #	backend/src/main/java/com/bakdata/conquery/models/query/resultinfo/ResultInfo.java
    #	backend/src/main/java/com/bakdata/conquery/models/query/resultinfo/printers/ResultPrinters.java
    #	backend/src/test/java/com/bakdata/conquery/integration/common/IntegrationUtils.java
    #	backend/src/test/java/com/bakdata/conquery/integration/json/FormTest.java
    #	backend/src/test/java/com/bakdata/conquery/io/result/ResultTestUtil.java
    #	backend/src/test/java/com/bakdata/conquery/io/result/excel/ExcelResultRenderTest.java
    #	backend/src/test/java/com/bakdata/conquery/models/events/stores/types/ColumnStoreSerializationTests.java
    #	backend/src/test/java/com/bakdata/conquery/models/types/ResultTypeTest.java
    awildturtok committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    256b651 View commit details
    Browse the repository at this point in the history