1309 Monitoring add sentry configuration #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecarn
commented
Aug 11, 2023
| }, | ||
| queryHtmlTarget: 'iframe', | ||
| count: 30 | ||
| // TODO pelord, serais-tu en mesure de corriger l'interface? |
There was a problem hiding this comment.
@pelord J'ai ajouté le typage pour les configurations d'IGO.
Est-ce que tu pourrais vérifier les TODOS et essayer de conformer les interfaces ou la config?
…into 1309-application-monitoring-add-sentry-configuration-2
…into 1309-application-monitoring-add-sentry-configuration-2
…into 1309-application-monitoring-add-sentry-configuration-2
…into 1309-application-monitoring-add-sentry-configuration-2
…into 1309-application-monitoring-add-sentry-configuration-2
…into 1309-application-monitoring-add-sentry-configuration-2
alecarn
deleted the
1309-application-monitoring-add-sentry-configuration-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sentry configuration for applicaiton monitoring
There is some limitation for the configuration, we need to override the Angular ErrorHandler and this provider is invoked at the APP_INITIALIZER stage. At this time, this is not possible to resolve the config.json via the ConfigService. We can only configure the monitoring options via the
environment.tsfile.Some IGO2 precompiled application like Forêt-Ouverte, will not be able to configure the monitoring. We opened another issue to track this limitation