Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export abci::event::v0_37 from abci module #1480

Merged

Conversation

SuperFluffy
Copy link
Contributor

Exporst crate::abci::event::v0_37 from its parent module crate::abci. This is fixing an oversight in #1479 that didn't pay attention to crate::abci::event being private.

  • Referenced an issue explaining the need for the change
  • [ ] Updated all relevant documentation in docs
  • [ ] Updated all code comments where relevant
  • [ ] Wrote tests
  • Added entry in .changelog/

@romac
Copy link
Member

romac commented Dec 12, 2024

Can you please apply this patch to fix no_std support (seems to have been broken in a recent js-sys release):

diff --git a/light-client-js/Cargo.toml b/light-client-js/Cargo.toml
index a27daee3..f32984a6 100644
--- a/light-client-js/Cargo.toml
+++ b/light-client-js/Cargo.toml
@@ -25,7 +25,8 @@ serde_json = { version = "1.0", default-features = false }
 tendermint = { version = "0.40.0", default-features = false, path = "../tendermint" }
 tendermint-light-client-verifier = { version = "0.40.0", features = ["rust-crypto"], default-features = false, path = "../light-client-verifier" }
 wasm-bindgen = { version = "0.2.63", default-features = false, features = [ "serde-serialize" ] }
-serde-wasm-bindgen = { version = "0.4.5", default-features = false }
+serde-wasm-bindgen = { version = "0.6.5", default-features = false }
+js-sys = { version = "=0.3.70", default-features = false }

@SuperFluffy
Copy link
Contributor Author

Can you please apply this patch to fix no_std support (seems to have been broken in a recent js-sys release):

diff --git a/light-client-js/Cargo.toml b/light-client-js/Cargo.toml
index a27daee3..f32984a6 100644
--- a/light-client-js/Cargo.toml
+++ b/light-client-js/Cargo.toml
@@ -25,7 +25,8 @@ serde_json = { version = "1.0", default-features = false }
 tendermint = { version = "0.40.0", default-features = false, path = "../tendermint" }
 tendermint-light-client-verifier = { version = "0.40.0", features = ["rust-crypto"], default-features = false, path = "../light-client-verifier" }
 wasm-bindgen = { version = "0.2.63", default-features = false, features = [ "serde-serialize" ] }
-serde-wasm-bindgen = { version = "0.4.5", default-features = false }
+serde-wasm-bindgen = { version = "0.6.5", default-features = false }
+js-sys = { version = "=0.3.70", default-features = false }

I have created a clean patch to separate the concerns of this PR from the fix here: #1481

@romac romac merged commit 31f3bb5 into informalsystems:main Dec 12, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants