Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure project #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Restructure project #2

wants to merge 2 commits into from

Conversation

chriskamphuis
Copy link
Contributor

Moved run files to seperate folder
Fixed PEP8 issues

@chriskamphuis
Restructure project
9598069 
Moved run files to seperate folder
Fixed PEP8 issues
KDercksen
KDercksen reviewed May 11, 2020
View reviewed changes
Copy link
Contributor

@KDercksen KDercksen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe consistent snake_case across files? Other than that seems fine :)

@chriskamphuis
Copy link
Contributor Author

I see I missed one file, search.py needs more attention in general as it contains error. And apparently not all threw a warning, so I will look a bit more closely to make sure everything is in fact refactored to snake case.

KDercksen
KDercksen reviewed May 11, 2020
View reviewed changes
Copy link
Contributor

@KDercksen KDercksen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Maybe Thomas can include his changes in this PR, and then it can be merged in one go 😄

@chriskamphuis
Copy link
Contributor Author

@tmschoegje see comment from Koen above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KDercksen KDercksen KDercksen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriskamphuis @KDercksen