Configure restore-keys for puppeteer cache in ci:test
#975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flow. This fixes #865 for good. Since `meteor-actions/install` now can skip the installation of cached packages using restore keys, it can happen that `node_modules/puppeteer` is restored from cache while its `chromium` download is not. With this commit, we ensure that the weakest restore key for `chromium` is at least as weak as the weakest restore key for `node_modules/puppeteer`. Maybe an alternative would be to instruct `puppeteer` to install chromium under `node_modules`? But for now, this is good enough.
make-github-pseudonymous-again
temporarily deployed
to
Snyk
GitHub Actions
Inactive
make-github-pseudonymous-again
added
ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #975 +/- ##
==========================================
- Coverage 65.88% 65.86% -0.03%
==========================================
Files 715 715
Lines 9893 9893
Branches 1346 1346
==========================================
- Hits 6518 6516 -2
- Misses 2917 2919 +2
Partials 458 458
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #865 for good.
Since
meteor-actions/installnow can skip the installation of cached packages using restore keys, it can happen thatnode_modules/puppeteeris restored from cache while itschromiumdownload is not.With this commit, we ensure that the weakest restore key for
chromiumis at least as weak as the weakest restore key fornode_modules/puppeteer.Maybe an alternative would be to instruct
puppeteerto install chromium undernode_modules? But for now, this is good enough.