Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --init and init: true on main container #893

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

make-github-pseudonymous-again
Copy link
Contributor

Fixes #891.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.47%. Comparing base (77e7767) to head (fab06e5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #893   +/-   ##
=======================================
  Coverage   64.47%   64.47%           
=======================================
  Files         703      703           
  Lines        9705     9705           
  Branches     1335     1335           
=======================================
  Hits         6257     6257           
- Misses       3003     3004    +1     
+ Partials      445      444    -1     
Flag Coverage Δ
test 69.78% <ø> (+0.01%) ⬆️
test-app 53.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@make-github-pseudonymous-again make-github-pseudonymous-again marked this pull request as ready for review April 18, 2024 06:12
Merged via the queue into main with commit 5ffebff Apr 18, 2024
19 checks passed
@make-github-pseudonymous-again make-github-pseudonymous-again deleted the ci-docker-init-1 branch May 20, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Figure out whether we need tini as pid1 in containers
1 participant