Skip to content

Commit

Permalink
⚙️ config(ci): Configure restore key for puppeteer cache in test work…
Browse files Browse the repository at this point in the history
…flow.

This fixes #865 for good.

Since `meteor-actions/install` now can skip the installation of cached
packages using restore keys, it can happen that `node_modules/puppeteer`
is restored from cache while its `chromium` download is not.

With this commit, we ensure that the weakest restore key for `chromium`
is at least as weak as the weakest restore key for
`node_modules/puppeteer`.

Maybe an alternative would be to instruct `puppeteer` to install
chromium under `node_modules`? But for now, this is good enough.
  • Loading branch information
make-github-pseudonymous-again committed May 20, 2024
1 parent 6308ea8 commit 30a1651
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ jobs:
with:
path: ~/.cache/puppeteer
key: ${{ runner.os }}-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-${{ env.cache-name }}-
- name: Install 💾
uses: ./.github/actions/install
Expand Down

0 comments on commit 30a1651

Please sign in to comment.