Minor code updates from missed open comments from #36 to the migratedown feature #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-garcia
approved these changes
Oct 8, 2024
akleinib
reviewed
Oct 8, 2024
venkat-iblox
changed the title
venkat-iblox
changed the title
|
All my comments have been addressed However it doesn't seem that changes related to Docker and build pertain to this PR. |
Thank you, I have removed the files for building a local image for testing. We probably should add a few of these paths into |
akleinib
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addressed open comments from PR #36
runMigrationsfunction instead of explicitly checking if the dirty state handling is enabled