Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register pgx in main cli, not internal #30

Merged
merged 2 commits into from
Dec 8, 2023
Merged

register pgx in main cli, not internal #30

merged 2 commits into from
Dec 8, 2023

Conversation

daniel-garcia
Copy link

user@host migrate % go build
user@host migrate % ./migrate --database.driver hotload --database.dsn 'fsnotify://pgx/tmp/foo'
{"level":"info","msg":"error: could not get current_database: lstat /tmp/foo: no such file or directory","time":"2023-12-05T09:49:36-06:00"}

@coveralls
Copy link

coveralls commented Dec 5, 2023

Pull Request Test Coverage Report for Build 7103873237

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 57.461%

Files with Coverage Reduction New Missed Lines %
util.go 1 48.15%
Totals Coverage Status
Change from base Build 7101467101: 0.1%
Covered Lines: 3743
Relevant Lines: 6514

💛 - Coveralls

@daniel-garcia daniel-garcia merged commit aad2543 into hotload Dec 8, 2023
8 of 10 checks passed
@daniel-garcia daniel-garcia deleted the pgx_pg branch December 8, 2023 15:54
daniel-garcia added a commit that referenced this pull request Dec 8, 2023
* pgx migrate test (#29)

* add hotload support (#15)

* import fsync

* Upgrade alpine 3.13 -> 3.18 (#21)

* upgrade alpine 3.13 -> 3.18

* add --pull to docker build

* adding pgx as the supported hotload base driver (#26)

* adding pgx as the supported hotload base driver

* updating go.mod file

* removing the pgx register in migrate (#27)

* register hotload with pgx driver

---------

Co-authored-by: Daniel Garcia <[email protected]>
Co-authored-by: Ying Chen <[email protected]>
Co-authored-by: Supriya Gowda <[email protected]>

* register pgx in main cli, not internal (#30)

* register pgx in main cli, not internal

* go fmt

---------

Co-authored-by: Sujay Kumar Suman <[email protected]>
Co-authored-by: Ying Chen <[email protected]>
Co-authored-by: Supriya Gowda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants