Truncate the delete apiservice job name #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kd7lxl
approved these changes
Oct 26, 2023
| @@ -1,7 +1,7 @@ | |||
| apiVersion: batch/v1 | |||
| kind: Job | |||
| metadata: | |||
| name: {{ include "konk-service.fullname" . }}-delete-apiservice | |||
| name: {{ include "konk-service.fullname" . | trunc 43 }}-delete-apiservice | |||
There was a problem hiding this comment.
This is fine, but it might be a little more obvious to the reader to truncate the whole string to the actual limit like
Suggested change
| name: {{ include "konk-service.fullname" . | trunc 43 }}-delete-apiservice | |
| name: {{ printf "%s-delete-apiservice" (include "konk-service.fullname" .) | trunc 63 }} |
There was a problem hiding this comment.
Never mind, I think I prefer the way you did it originally. A really long name that truncates the entire -delete-apiservice part off the end could result in an ambiguous name.
There was a problem hiding this comment.
One thing I would do either way is trim double - like the helpers do:
Suggested change
| name: {{ include "konk-service.fullname" . | trunc 43 }}-delete-apiservice | |
| name: {{ include "konk-service.fullname" . | trunc 43 | trimSuffix "-" }}-delete-apiservice |
kd7lxl
approved these changes
Oct 26, 2023
abalaven
force-pushed
the
truncate-del-api-service-job-name
branch
from
962c6b2 to
1af2cad
Compare
abalaven
force-pushed
the
truncate-del-api-service-job-name
branch
from
1af2cad to
e1de851
Compare
kd7lxl
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed an error where a long konk-service release name could potentially prevent a delete-apiservice job from triggering as it would surpass the 63 character limit allowed for job names. This PR resolves this by truncating the length of the job name to less than 63 characters.