Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PTOCP-947: Client generated code for upgrade policy #43

Merged
merged 5 commits into from
May 10, 2024
Merged

PTOCP-947: Client generated code for upgrade policy #43

merged 5 commits into from
May 10, 2024

Conversation

shrutipathak2
Copy link
Contributor

@shrutipathak2 shrutipathak2 commented May 9, 2024 •
edited
Loading

Add Schedule Software/Config Updates support
PTOCP-947: Client generated code for upgrade policy

@shrutipathak2 shrutipathak2 marked this pull request as draft May 9, 2024 07:50
@mathewab
Copy link
Collaborator

mathewab commented May 9, 2024

looks like you have both models with and without prefix - model_service_v2_... and also model_...

Can you clean the entire directory and regenerate? Also, please run make fmt after generation.

@mathewab
Copy link
Collaborator

mathewab commented May 9, 2024

Please add the API to the project README (https://github.com/infobloxopen/bloxone-go-client/blob/master/README.md) and aggregated client (https://github.com/infobloxopen/bloxone-go-client/blob/master/client/client.go) as well

@shrutipathak2
Copy link
Contributor Author

looks like you have both models with and without prefix - model_service_v2_... and also model_...

Can you clean the entire directory and regenerate? Also, please run make fmt after generation.

Done

@shrutipathak2
Copy link
Contributor Author

Please add the API to the project README (https://github.com/infobloxopen/bloxone-go-client/blob/master/README.md) and aggregated client (https://github.com/infobloxopen/bloxone-go-client/blob/master/client/client.go) as well

Done

@shrutipathak2 shrutipathak2 requested a review from mathewab May 10, 2024 04:39
@shrutipathak2 shrutipathak2 marked this pull request as ready for review May 10, 2024 04:39
mathewab
mathewab reviewed May 10, 2024
View reviewed changes
README.md Outdated
@@ -19,6 +19,7 @@ The following Bloxone APIs are supported:
- [DNS Configuration](dns_config/README.md)
- [DNS Data](dns_data/README.md)
- [Keys](keys/README.md)
- [Upgrade Policy](upgradePolicy/README.md)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move this to be under ## Bloxone Cloud

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mathewab mathewab linked an issue May 10, 2024 that may be closed by this pull request
Add Schedule Software/Config Updates support #42
Closed
@shrutipathak2 shrutipathak2 requested a review from mathewab May 10, 2024 05:19
@mathewab mathewab merged commit 1e65332 into infobloxopen:master May 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathewab mathewab mathewab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Schedule Software/Config Updates support
2 participants
@shrutipathak2 @mathewab