Regenerate client from 7.0.1 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewab
reviewed
Jan 29, 2024
| @@ -19,7 +19,7 @@ Name | Type | Description | Notes | |||
|
|
|||
| ### NewHostactivationJoinToken | |||
|
|
|||
| `func NewHostactivationJoinToken() *HostactivationJoinToken` | |||
| `func NewHostactivationJoinToken(name string, ) *HostactivationJoinToken` | |||
There was a problem hiding this comment.
This change is unexpected for this PR. Also name is supposed to be required. But previously it was generated with name as optional. Having this change will require the terraform provider to be fixed as well.
There was a problem hiding this comment.
As discussed, also update Terraform Provider.
mathewab
reviewed
Jan 29, 2024
| @param ctx context.Context - for authentication, logging, cancellation, deadlines, tracing, etc. Passed from http.Request or context.Background(). | ||
| @return ApiKeysKerberosPostRequest | ||
| */ | ||
| KeysKerberosPost(ctx context.Context) ApiKeysKerberosPostRequest |
There was a problem hiding this comment.
This change is unexpected for this PR.
Maybe Post method was excluded from the schema, the first time it was generated, and the changes were not pushed.
mathewab
changed the title
mathewab
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go fmtgo fmtagain