Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPAM Address Support for Bloxone Ansible v2 #55

Open
wants to merge 7 commits into
base: v2
Choose a base branch
from

Conversation

ybhalchim
Copy link

No description provided.

id=dict(type="str", required=False),
filters=dict(type="dict", required=False),
filter_query=dict(type="str", required=False),
inherit=dict(type="str", required=False, choices=["full", "partial", "none"], default="full"),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if ipam_address supports inherit param

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


def find_by_id(self):
try:
resp = AddressApi(self.client).read(self.params["id"], inherit="full")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all instances of inherit if not supported

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@unasra unasra changed the title ipam_address Support for Bloxone Ansible v2 IPAM Address Support for Bloxone Ansible v2 Dec 17, 2024
@unasra unasra self-requested a review December 17, 2024 05:42
@unasra
Copy link
Collaborator

unasra commented Dec 17, 2024

Missing change logs and deprecation notices for this object .

Earlier this module was termed as ipv4_reservation !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants