-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPAM Address Support for Bloxone Ansible v2 #55
base: v2
Are you sure you want to change the base?
Conversation
plugins/modules/ipam_address_info.py
Outdated
id=dict(type="str", required=False), | ||
filters=dict(type="dict", required=False), | ||
filter_query=dict(type="str", required=False), | ||
inherit=dict(type="str", required=False, choices=["full", "partial", "none"], default="full"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check if ipam_address supports inherit param
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
plugins/modules/ipam_address_info.py
Outdated
|
||
def find_by_id(self): | ||
try: | ||
resp = AddressApi(self.client).read(self.params["id"], inherit="full") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all instances of inherit if not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Missing change logs and deprecation notices for this object . Earlier this module was termed as ipv4_reservation ! |
No description provided.