Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tsig keys Support for Bloxone Ansible v2 #51

Open
wants to merge 15 commits into
base: v2
Choose a base branch
from

Conversation

AnilGadiyarHJ
Copy link
Collaborator

sanity check - passed
integration - passed
example - added
lint check - passed

@AnilGadiyarHJ AnilGadiyarHJ marked this pull request as ready for review December 23, 2024 18:46
@AnilGadiyarHJ AnilGadiyarHJ requested a review from unasra December 23, 2024 18:47
plugins/modules/tsig_key.py Outdated Show resolved Hide resolved
plugins/modules/tsig_key.py Outdated Show resolved Hide resolved
plugins/modules/tsig_key.py Outdated Show resolved Hide resolved
plugins/modules/tsig_key_info.py Outdated Show resolved Hide resolved
plugins/modules/tsig_key.py Outdated Show resolved Hide resolved
plugins/modules/tsig_key.py Outdated Show resolved Hide resolved
tests/integration/targets/keys_tsig_info/tasks/main.yml Outdated Show resolved Hide resolved
@unasra
Copy link
Collaborator

unasra commented Jan 13, 2025

Can we add support for generat_tsig endpoint. ,where in a random Secret is generated automatically by the backend ?
Attached docs for reference :
https://csp.infoblox.com/apidoc?url=https%3A%2F%2Fcsp.infoblox.com%2Fapidoc%2Fdocs%2FDDIKeys#/

@AnilGadiyarHJ AnilGadiyarHJ requested a review from unasra January 21, 2025 07:11
plugins/modules/tsig_key.py Show resolved Hide resolved
plugins/modules/tsig_key.py Outdated Show resolved Hide resolved
plugins/modules/tsig_key.py Outdated Show resolved Hide resolved
plugins/modules/tsig_key_info.py Outdated Show resolved Hide resolved
plugins/modules/tsig_key_info.py Outdated Show resolved Hide resolved
tests/integration/targets/keys_tsig/tasks/main.yml Outdated Show resolved Hide resolved
tests/integration/targets/keys_tsig/tasks/main.yml Outdated Show resolved Hide resolved
@unasra unasra added the donotmerge Do not Merge this Pull request label Jan 21, 2025
@AnilGadiyarHJ AnilGadiyarHJ requested a review from unasra January 22, 2025 10:17

def find_by_id(self):
try:
resp = TsigApi(self.client).read(self.params["id"], inherit="full")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Tsig support inheritance fields ?

RETURN = r"""
id:
description:
- ID of the Tsig object
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ID of the Tsig object
- ID of the TSIG object

returned: Always
objects:
description:
- Tsig object
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Tsig object
- TSIG object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
donotmerge Do not Merge this Pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants