Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented IPAM Range #48

Open
wants to merge 8 commits into
base: v2
Choose a base branch
from

Conversation

JchhatbarInfoblox
Copy link
Collaborator

Implemented IPAM Range

@JchhatbarInfoblox JchhatbarInfoblox marked this pull request as ready for review December 3, 2024 08:06
changelogs/fragments/38-range.yml Outdated Show resolved Hide resolved
meta/runtime.yml Outdated Show resolved Hide resolved
plugins/modules/ipam_range.py Show resolved Hide resolved
plugins/modules/b1_ipam_range.py Outdated Show resolved Hide resolved
tests/integration/targets/ipam_range/tasks/main.yml Outdated Show resolved Hide resolved
state: "absent"
ignore_errors: true

- name: "Delete IP Space"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a standardized cleanup file in setup_ip_space instead of this and call that from here ?
Something like :

- ansible.builtin.include_role:
    name: "setup_ip_space"
    tasks_from: "cleanup.yml"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isnt resolved yet.

space: "{{ ip_space.id }}"
disable_dhcp: "true"
tags:
location: "some where on earth"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
location: "some where on earth"
location: "site-1"

- infoblox.bloxone.common
"""
EXAMPLES = r"""
- name: "Create an ip space"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: "Create an ip space"
- name: "Create an IP Space"

state: "present"
register: ip_space

- name: "Create a subnet"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: "Create a subnet"
- name: "Create a Subnet"

infoblox.bloxone.ipam_range:
start: "10.0.0.1"
end: "10.0.0.100"
space: "{{ _ip_space.id }}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
space: "{{ _ip_space.id }}"
space: "{{ ip_space.id }}"

low: 10
state: "present"

- name: "Delete a Range"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: "Delete a Range"
- name: "Delete the Range"

"""

EXAMPLES = r"""
- name: Retrieve range information by ID
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Retrieve range information by ID
- name: Get Range information by ID

ipam_range_info:
id: "range-id-12345"

- name: Retrieve range information with filters
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Retrieve range information with filters
- name: Get Range information with filters (eg. start , end)

start: "192.168.1.0"
end: "192.168.1.255"

- name: Retrieve range information with filter query
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Retrieve range information with filter query
- name: Get Range information with filter query

- name: Retrieve range information with filter query
ipam_range_info:
filter_query: "start=='10.0.0.1' and end=='10.0.0.100'"
"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an examples of filtering using Tag Filters ?

type: dict
returned: Always
contains:
abandoned:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update descriptions please !

space: "{{ _ip_space.id }}"
state: "absent"

- ansible.builtin.include_role:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I mean that there could be separate directories called cleanup_ip_space and cleanup_subnet which can be called in dependencies where the cleanup takes place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants