DNS Forward NSG Support for Bloxone Ansible v2 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unasra
reviewed
Dec 2, 2024
| name: "{{ forward_nsg_name }}" | ||
| state: present | ||
| register: forward_nsg | ||
| - name: Get Information about the Forward NSG |
There was a problem hiding this comment.
Add a new line here please !
There was a problem hiding this comment.
This comment is yet to be addressed .
We need a line between lines 16 and 17 to differentiate between creation and the several retrieval methods.
unasra
reviewed
Dec 16, 2024
| name: "{{ forward_nsg_name }}" | ||
| state: present | ||
| register: forward_nsg | ||
| - name: Get Information about the Forward NSG |
There was a problem hiding this comment.
This comment is yet to be addressed .
We need a line between lines 16 and 17 to differentiate between creation and the several retrieval methods.
unasra
reviewed
Dec 23, 2024
| - name: Get Forward NSG information by filters (e.g. name) | ||
| infoblox.bloxone.dns_forward_nsg_info: | ||
| filters: | ||
| name: "example_nsg" |
| - "{{ forward_nsg.id }}" | ||
| state: present | ||
| register: secondary_forward_nsg | ||
| - name: Validate Secondary Forward NSG Creation |
There was a problem hiding this comment.
IS this validation or the Get Information about the Secondary Forward NSG ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for forward NSG in v2 ansible
Integration test - pass
Sanity - pass
Lint check - pass