DNS Auth NSG Support for Bloxone Ansible v2 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unasra
reviewed
Dec 2, 2024
unasra
reviewed
Dec 16, 2024
| auth_nsg_name: "test-auth-nsg-{{ 999999 | random | string }}" | ||
| secondary_auth_nsg_name: "test-secondary-auth-nsg-{{ 999999 | random | string }}" | ||
|
|
||
| # - name: Create an Auth NSG (check mode) |
There was a problem hiding this comment.
Why is this code commented out ?
| - secondary_auth_nsg_info.objects | length == 1 | ||
| - secondary_auth_nsg_info.objects[0].nsgs | length == 1 | ||
| - secondary_auth_nsg_info.objects[0].nsgs[0] == auth_nsg.id | ||
| - block: # Unlinking block |
There was a problem hiding this comment.
The Unlinking is quite unnecessary . If the the unlinking is performed because it's interfering with the deletion of the primary object , why not delete the secondary object first in the always section and then cleanup the Primary.
| # - auth_nsg_info.objects[0].id == auth_nsg.id | ||
| # - auth_nsg_info.objects[0].tags.location == "site-1" | ||
|
|
||
| - name: Create the Primary Auth NSG |
There was a problem hiding this comment.
We can use Primary NSG to be the one that is created using the task with Tags above , no need to create an additional NSG !
plugins/modules/dns_auth_nsg.py
Outdated
| type: "primary" | ||
| state: "present" | ||
| tags: | ||
| location: "my-location" |
There was a problem hiding this comment.
Suggested change
| location: "my-location" | |
| location: "site-1" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.