-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Enable revive:enforce-slice-style
rule
#16173
chore: Enable revive:enforce-slice-style
rule
#16173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zak-pawel! Just one minor comment.
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zak-pawel!
(cherry picked from commit 0d30797)
Summary
Address last findings for revive:enforce-slice-style and enable this rule.
As we agreed here #15812, findings found by the following configuration were addressed:
By the way, I found one test in
config/config_test.go
that was skipped.However, since #3642 has already been resolved, I re-enabled this test.
Checklist
Related issues
resolves #15812