Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable revive:enforce-slice-style rule #16173

Merged

Conversation

zak-pawel
Copy link
Collaborator

Summary

Address last findings for revive:enforce-slice-style and enable this rule.

As we agreed here #15812, findings found by the following configuration were addressed:

      - name: enforce-slice-style
        arguments: ["make"]

By the way, I found one test in config/config_test.go that was skipped.
However, since #3642 has already been resolved, I re-enabled this test.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15812

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zak-pawel! Just one minor comment.

cmd/telegraf/cmd_win_service_notwindows.go Outdated Show resolved Hide resolved
@telegraf-tiger
Copy link
Contributor

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zak-pawel!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 12, 2024
@srebhan srebhan assigned DStrand1 and unassigned srebhan Nov 12, 2024
@DStrand1 DStrand1 merged commit 0d30797 into influxdata:master Nov 13, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.3 milestone Nov 13, 2024
srebhan pushed a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore linter ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
3 participants