Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logger): Avoid setting the log-format default too early #16108

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Oct 30, 2024

Summary

When using the old logtarget setting with eventlog we cannot detect if the logformat was set because it is already initialized with the text default in the agent-config. This PR moves the default handling to later in order to not error if the new logformat was not set.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16100

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 1, 2024
@srebhan srebhan assigned DStrand1 and unassigned srebhan Nov 1, 2024
@DStrand1 DStrand1 merged commit 5793ff6 into influxdata:master Nov 1, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.3 milestone Nov 1, 2024
s-r-engineer pushed a commit to s-r-engineer/telegraf that referenced this pull request Nov 11, 2024
srebhan added a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent area/configuration area/logging fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.32.X Windows logtarget setting deprecation seems like a breaking change
2 participants