Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(specs): Add specification for partial-write errors #16034

Merged
merged 2 commits into from
Nov 6, 2024
Merged

docs(specs): Add specification for partial-write errors #16034

merged 2 commits into from
Nov 6, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Oct 16, 2024

Summary

Add specification for handling partial-write errors on outputs, defining the behavior and error content

Checklist

  • No AI generated code was used in this PR

Related issues

related to #11942
related to #14802
related to #15908
related to #15742

@telegraf-tiger telegraf-tiger bot added the docs Issues related to Telegraf documentation and configuration descriptions label Oct 16, 2024
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 16, 2024
@srebhan srebhan mentioned this pull request Oct 16, 2024
Open
@srebhan srebhan marked this pull request as draft October 16, 2024 18:35
DStrand1
DStrand1 reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@DStrand1 DStrand1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just have one question and a small fix

docs/specs/tsd-008-partial-write-error-handling.md Show resolved Hide resolved
docs/specs/tsd-008-partial-write-error-handling.md Outdated Show resolved Hide resolved
@srebhan srebhan marked this pull request as ready for review October 29, 2024 10:37
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Nov 4, 2024

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@DStrand1 DStrand1 assigned srebhan and unassigned DStrand1 Nov 5, 2024
powersj
powersj approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srebhan

@srebhan srebhan merged commit 4f951e6 into influxdata:master Nov 6, 2024
27 checks passed
@srebhan srebhan deleted the spec_partial_write_error branch November 6, 2024 13:36
@github-actions github-actions bot added this to the v1.32.3 milestone Nov 6, 2024
s-r-engineer pushed a commit to s-r-engineer/telegraf that referenced this pull request Nov 11, 2024
@srebhan @s-r-engineer
docs(specs): Add specification for partial-write errors (influxdata#1…
42bbedb 
…6034)
srebhan added a commit that referenced this pull request Nov 18, 2024
@srebhan
docs(specs): Add specification for partial-write errors (#16034)
7bc2467 
(cherry picked from commit 4f951e6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DStrand1 DStrand1 DStrand1 approved these changes

@powersj powersj powersj approved these changes

Assignees

@srebhan srebhan

Labels
docs Issues related to Telegraf documentation and configuration descriptions ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.32.3
Development

Successfully merging this pull request may close these issues.
3 participants
@srebhan @powersj @DStrand1