Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(outputs.sql): Fix clean up of sql database file #13918

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Sep 12, 2023

The test file was not removed after testing. Additional runs of the test would conflict if this file still existed.

The test file was not removed after testing. Additional runs of the test
would conflict if this file still existed.
@telegraf-tiger telegraf-tiger bot added area/sql plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins test labels Sep 12, 2023
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 12, 2023
@telegraf-tiger
Copy link
Contributor

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment...

plugins/outputs/sql/sqlite_test.go Show resolved Hide resolved
@srebhan srebhan merged commit ae9668b into influxdata:master Sep 14, 2023
4 checks passed
@github-actions github-actions bot added this to the v1.29.0 milestone Sep 14, 2023
powersj added a commit that referenced this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sql plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants