Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(outputs.prometheus_client): Add secretstore support for basic_password #13899

Merged
merged 7 commits into from
Sep 11, 2023
Merged

feat(outputs.prometheus_client): Add secretstore support for basic_password #13899

merged 7 commits into from
Sep 11, 2023

Conversation

yonathanamir
Copy link
Contributor

@yonathanamir yonathanamir commented Sep 10, 2023

  • Updated associated README.md.
  • Wrote appropriate unit tests.
  • Pull request title or commits are in [conventional commit format]

resolves #13898

Changes the Prometheus Client output basic_password option to support using the secretstore.

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Sep 10, 2023
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yonathanamir for your contribution. Only one comment...

plugins/outputs/prometheus_client/prometheus_client.go Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Sep 11, 2023
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yonathanamir!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 11, 2023
@srebhan srebhan assigned powersj and unassigned srebhan Sep 11, 2023
@srebhan srebhan changed the title feat(outputs.prometheus_client): basic_password secretstore support feat(outputs.prometheus_client): Add secretstore support for basic_password Sep 11, 2023
@telegraf-tiger
Copy link
Contributor

@powersj powersj merged commit a057e5b into influxdata:master Sep 11, 2023
5 checks passed
@github-actions github-actions bot added this to the v1.28.0 milestone Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prometheus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus Client output secretstore password support.
3 participants