Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sql): Allow sqlite on Windows (amd64 and arm64) #13865

Merged
merged 2 commits into from
Sep 8, 2023
Merged

fix(sql): Allow sqlite on Windows (amd64 and arm64) #13865

merged 2 commits into from
Sep 8, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Sep 5, 2023

fixes: #13859

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Sep 5, 2023
@powersj powersj mentioned this pull request Sep 5, 2023
Closed
@powersj powersj force-pushed the fix/13859 branch 3 times, most recently from ad1bf8f to 6744b39 Compare September 7, 2023 19:45
@powersj powersj changed the title fix(sql): Allow sqlite on Windows fix(sql): Allow sqlite on Windows (amd64 and arm64) Sep 8, 2023
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Sep 8, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 8, 2023
@powersj powersj marked this pull request as ready for review September 8, 2023 17:55
srebhan
srebhan approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up @powersj!

@srebhan srebhan added plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins area/sql labels Sep 8, 2023
@srebhan srebhan merged commit c238ebb into influxdata:master Sep 8, 2023
5 checks passed
@github-actions github-actions bot added this to the v1.28.0 milestone Sep 8, 2023
athornton pushed a commit to lsst-sqre/telegraf that referenced this pull request Sep 8, 2023
@powersj @athornton
fix(sql): Allow sqlite on Windows (amd64 and arm64) (influxdata#13865)
f9fdeae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
area/sql fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.28.0
Development

Successfully merging this pull request may close these issues.

driver "sqlite" not supported
2 participants
@powersj @srebhan