Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parsers.avro): Allow connection to https schema registry #13820

Closed

Conversation

BelousovAntonV
Copy link
Contributor

@BelousovAntonV BelousovAntonV commented Aug 23, 2023

Required for all PRs

Resolves #13334

Authorization base64 string and ca certificate path options are added to the config. Now creating a client instead of simple request to the schema registry.

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins labels Aug 23, 2023
@BelousovAntonV
Copy link
Contributor Author

!signed-cla

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the valuable contribution @BelousovAntonV! I have some comments with the most important one being to split the authentication option into username and password to ease the use.

Alternatively, we can pass in credentials via the avro_schema_registry option e.g.
avro_schema_registry = "http://evil:bifh@localhost:8081". What do you think?

plugins/parsers/avro/README.md Show resolved Hide resolved
plugins/parsers/avro/parser.go Show resolved Hide resolved
plugins/parsers/avro/schema_registry.go Outdated Show resolved Hide resolved
plugins/parsers/avro/schema_registry.go Show resolved Hide resolved
plugins/parsers/avro/schema_registry.go Show resolved Hide resolved
@srebhan srebhan changed the title feat(parser.avro): connect to the schema registry over https feat(parsers.avro): connect to the schema registry over https Aug 29, 2023
@srebhan srebhan changed the title feat(parsers.avro): connect to the schema registry over https feat(parsers.avro): Allow connection to https schema registry Aug 29, 2023
@powersj powersj added the waiting for response waiting for response from contributor label Aug 29, 2023
@srebhan srebhan self-assigned this Aug 30, 2023
@srebhan
Copy link
Member

srebhan commented Sep 11, 2023

@BelousovAntonV I incorporated my suggestions in #13903 and am closing this PR in favorite of the other one...

@srebhan srebhan closed this Sep 11, 2023
@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Sep 11, 2023
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

🥳 This pull request decreases the Telegraf binary size by -1.02 % for linux amd64 (new size: 195.0 MB, nightly size 197.0 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@BelousovAntonV
Copy link
Contributor Author

@BelousovAntonV I incorporated my suggestions in #13903 and am closing this PR in favorite of the other one...

Thank you a lot. Did not have a chance to work on it.

@BelousovAntonV BelousovAntonV deleted the parser_avro_ca_cert branch September 12, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avro parser plugin can not connect to the schema registry over "https".
3 participants