-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parsers.avro): Allow connection to https schema registry #13820
feat(parsers.avro): Allow connection to https schema registry #13820
Conversation
Thanks so much for the pull request! |
!signed-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the valuable contribution @BelousovAntonV! I have some comments with the most important one being to split the authentication option into username
and password
to ease the use.
Alternatively, we can pass in credentials via the avro_schema_registry
option e.g.
avro_schema_registry = "http://evil:bifh@localhost:8081"
. What do you think?
@BelousovAntonV I incorporated my suggestions in #13903 and am closing this PR in favorite of the other one... |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 🥳 This pull request decreases the Telegraf binary size by -1.02 % for linux amd64 (new size: 195.0 MB, nightly size 197.0 MB) 📦 Click here to get additional PR build artifactsArtifact URLs |
Thank you a lot. Did not have a chance to work on it. |
Required for all PRs
Resolves #13334
Authorization base64 string and ca certificate path options are added to the config. Now creating a client instead of simple request to the schema registry.