Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.cisco_telemetry_mdt): Check for slice length #13813

Closed
wants to merge 1 commit into from

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Aug 22, 2023

fixes: #13789

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Aug 22, 2023
Comment on lines +419 to +422
if len(subfield.Fields) == 0 {
continue
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will quote @srebhan from #12637 ;)
"Hmmm, are you sure that parseContentField will always fail if there are not fields or does it in some cases return a sensible value?"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha good point - let's see what the user finds with respect to the crash first

@powersj powersj self-assigned this Aug 25, 2023
@powersj powersj closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
2 participants