Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Spell endianness correctly #13752

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Aug 11, 2023

A forums user tried using endianness as a setting for the binary plugin. However, that is not what the plugin is using, instead, it is using endianess (one less n).

This PR changes all internal uses to use endianness and deprecates the binary parser's current endianess setting in favor of endianness.

@telegraf-tiger telegraf-tiger bot added the chore label Aug 11, 2023
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 11, 2023
@telegraf-tiger
Copy link
Contributor

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj and sorry for introducing most of the misspellings!

@srebhan srebhan merged commit 013b732 into influxdata:master Aug 14, 2023
4 checks passed
@github-actions github-actions bot added this to the v1.27.4 milestone Aug 14, 2023
powersj added a commit that referenced this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants