feat: cleanup target #149
Merged
feat: cleanup target #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements finalizer to logic to ensure deletion of target resources when a ResourceSync is deleted as described here. Also adds ResourceSync as an owner reference to local targets as described here. I tried to create some create some white-box style unit tests, but it ended up being too complex to be worthwhile. Integration tests run against a kind cluster would be a lot simpler and more practical, so I have created an issue for this to be implemented at some point, but I figured this should be safe to merge before that since the controller code is still relatively simple and I have tested it manually in my local environment. I ended up doing some reorganizing and minor refactoring to get this all to work and to make things more readable, but unfortunately that will make the PR a bit large and difficult to review even though a lot of it is just moving code that already exists around to different places.