Skip to content

[WIP] Break down JxlDecoder to better support streaming, preview, animation, etc. #434

[WIP] Break down JxlDecoder to better support streaming, preview, animation, etc.

[WIP] Break down JxlDecoder to better support streaming, preview, animation, etc. #434

GitHub Actions / clippy failed Oct 11, 2024 in 0s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (3)

jpegxl-rs/src/decode/session.rs|246 col 13| error: unused variable: name
--> jpegxl-rs/src/decode/session.rs:246:13
|
246 | let name = CString::from_vec_with_nul(buffer)
| ^^^^ help: if this is intentional, prefix it with an underscore: _name
|
= note: -D unused-variables implied by -D warnings
= help: to override -D warnings add #[allow(unused_variables)]
jpegxl-rs/src/decode/session.rs|30 col 19| error: field frame is never read
--> jpegxl-rs/src/decode/session.rs:33:9
|
30 | pub(crate) struct Config {
| ------ field in this struct
...
33 | pub frame: Option,
| ^^^^^
|
= note: Config has derived impls for the traits Default and Debug, but these are intentionally ignored during dead code analysis
= note: -D dead-code implied by -D warnings
= help: to override -D warnings add #[allow(dead_code)]
jpegxl-rs/src/decode/session.rs|45 col 12| error: field state is never read
--> jpegxl-rs/src/decode/session.rs:50:5
|
45 | pub struct Session<'dec, 'pr, 'mm> {
| ------- field in this struct
...
50 | state: State,
| ^^^^^

Filtered Findings (0)

Annotations

Check failure on line 246 in jpegxl-rs/src/decode/session.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] jpegxl-rs/src/decode/session.rs#L246

error: unused variable: `name`
   --> jpegxl-rs/src/decode/session.rs:246:13
    |
246 |         let name = CString::from_vec_with_nul(buffer)
    |             ^^^^ help: if this is intentional, prefix it with an underscore: `_name`
    |
    = note: `-D unused-variables` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(unused_variables)]`
Raw output
jpegxl-rs/src/decode/session.rs:246:13:e:error: unused variable: `name`
   --> jpegxl-rs/src/decode/session.rs:246:13
    |
246 |         let name = CString::from_vec_with_nul(buffer)
    |             ^^^^ help: if this is intentional, prefix it with an underscore: `_name`
    |
    = note: `-D unused-variables` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(unused_variables)]`


__END__

Check failure on line 30 in jpegxl-rs/src/decode/session.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] jpegxl-rs/src/decode/session.rs#L30

error: field `frame` is never read
  --> jpegxl-rs/src/decode/session.rs:33:9
   |
30 | pub(crate) struct Config {
   |                   ------ field in this struct
...
33 |     pub frame: Option<usize>,
   |         ^^^^^
   |
   = note: `Config` has derived impls for the traits `Default` and `Debug`, but these are intentionally ignored during dead code analysis
   = note: `-D dead-code` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(dead_code)]`
Raw output
jpegxl-rs/src/decode/session.rs:30:19:e:error: field `frame` is never read
  --> jpegxl-rs/src/decode/session.rs:33:9
   |
30 | pub(crate) struct Config {
   |                   ------ field in this struct
...
33 |     pub frame: Option<usize>,
   |         ^^^^^
   |
   = note: `Config` has derived impls for the traits `Default` and `Debug`, but these are intentionally ignored during dead code analysis
   = note: `-D dead-code` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(dead_code)]`


__END__

Check failure on line 45 in jpegxl-rs/src/decode/session.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] jpegxl-rs/src/decode/session.rs#L45

error: field `state` is never read
  --> jpegxl-rs/src/decode/session.rs:50:5
   |
45 | pub struct Session<'dec, 'pr, 'mm> {
   |            ------- field in this struct
...
50 |     state: State,
   |     ^^^^^
Raw output
jpegxl-rs/src/decode/session.rs:45:12:e:error: field `state` is never read
  --> jpegxl-rs/src/decode/session.rs:50:5
   |
45 | pub struct Session<'dec, 'pr, 'mm> {
   |            ------- field in this struct
...
50 |     state: State,
   |     ^^^^^


__END__