Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly configure libdir to lib #39

Closed
wants to merge 1 commit into from

Conversation

Szpadel
Copy link

@Szpadel Szpadel commented Feb 29, 2024

Without this setting static library
is placed in lib or lib64 depending on platform

Without this setting static library 
is placed in lib or lib64 depending on platform
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.18%. Comparing base (4a36ba0) to head (982a540).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files          12       12           
  Lines         854      854           
=======================================
  Hits          847      847           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inflation
Copy link
Owner

I guess I shouldn't hardcode the library path, since the user could modify it by env as well. Perhaps reading from the generated pkg-config?

@Szpadel
Copy link
Author

Szpadel commented Mar 1, 2024

Also sounds like solution.
I'm not familiar with enough with pkg-config and cmake configurations, therefore I failed to influence that from env.
For me any way that would make this reliable is good.
I found that linux defaults to lib64 and macos to lib therefore if you want to test that locally (I'm assuming you use macos from hardcoded path) docker should be easiest way

inflation added a commit that referenced this pull request Apr 30, 2024
Thanks @Szpadel for CMAKE_INSTALL_LIBDIR tip (#39).
@inflation
Copy link
Owner

Integrated in #46. Thanks.

@inflation inflation closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants