♻️ Use [lints] in Cargo.toml

Cargo.toml

@@ -1,3 +1,3 @@
 [workspace]
 members = ["jpegxl-src", "jpegxl-sys", "jpegxl-rs"]
-resolver = "2"
+resolver = "2"

jpegxl-rs/Cargo.toml

@@ -12,6 +12,12 @@ version = "0.8.3+libjxl-0.8.2"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
+[lints.rust]
+missing_docs = "warn"
+
+[lints.clippy]
+pedantic = "warn"
+
 [features]
 default = ["image", "threads"]
 image = ["dep:image"]

jpegxl-rs/benches/decode.rs

@@ -1,5 +1,8 @@
+#![allow(missing_docs)]
+#![allow(clippy::missing_panics_doc)]
+
 use criterion::{black_box, criterion_group, criterion_main, Criterion};
-use jpegxl_rs::*;
+use jpegxl_rs::{decoder_builder, parallel, ResizableRunner};
 use parallel::threads_runner::ThreadsRunner;
 
 const SAMPLE: &[u8] = include_bytes!("../../samples/bench.jxl");
@@ -10,7 +13,7 @@ pub fn criterion_benchmark(c: &mut Criterion) {
 
     let decoder = decoder_builder().build().unwrap();
     group.bench_function("single thread", |b| {
-        b.iter_with_large_drop(|| decoder.decode_with::<u8>(black_box(SAMPLE)).unwrap())
+        b.iter_with_large_drop(|| decoder.decode_with::<u8>(black_box(SAMPLE)).unwrap());
     });
 
     let parallel_runner = ThreadsRunner::default();
@@ -19,7 +22,7 @@ pub fn criterion_benchmark(c: &mut Criterion) {
         .build()
         .unwrap();
     group.bench_function("thread pool using default number of threads", |b| {
-        b.iter_with_large_drop(|| decoder.decode_with::<u8>(black_box(SAMPLE)).unwrap())
+        b.iter_with_large_drop(|| decoder.decode_with::<u8>(black_box(SAMPLE)).unwrap());
     });
 
     let parallel_runner = ResizableRunner::default();
@@ -28,7 +31,7 @@ pub fn criterion_benchmark(c: &mut Criterion) {
         .build()
         .unwrap();
     group.bench_function("resizable thread pool", |b| {
-        b.iter_with_large_drop(|| decoder.decode_with::<u8>(black_box(SAMPLE)).unwrap())
+        b.iter_with_large_drop(|| decoder.decode_with::<u8>(black_box(SAMPLE)).unwrap());
     });
 
     group.finish();

jpegxl-rs/benches/encode.rs

@@ -1,3 +1,6 @@
+#![allow(missing_docs)]
+#![allow(clippy::missing_panics_doc)]
+
 use criterion::{black_box, criterion_group, criterion_main, Criterion};
 use jpegxl_rs::{encoder_builder, ResizableRunner, ThreadsRunner};
 
@@ -16,7 +19,7 @@ pub fn criterion_benchmark(c: &mut Criterion) {
             encoder
                 .encode::<_, u8>(black_box(sample.as_raw()), sample.width(), sample.height())
                 .unwrap()
-        })
+        });
     });
 
     let parallel_runner = ThreadsRunner::default();
@@ -29,7 +32,7 @@ pub fn criterion_benchmark(c: &mut Criterion) {
             encoder
                 .encode::<_, u8>(black_box(sample.as_raw()), sample.width(), sample.height())
                 .unwrap()
-        })
+        });
     });
 
     let parallel_runner = ResizableRunner::default();
@@ -42,7 +45,7 @@ pub fn criterion_benchmark(c: &mut Criterion) {
             encoder
                 .encode::<_, u8>(black_box(sample.as_raw()), sample.width(), sample.height())
                 .unwrap()
-        })
+        });
     });
 
     group.finish();

jpegxl-rs/src/decode.rs

@@ -219,15 +219,15 @@ impl<'pr, 'mm> JxlDecoder<'pr, 'mm> {
 
         let mut status;
         loop {
-            use JxlDecoderStatus::*;
+            use JxlDecoderStatus as s;
 
             status = unsafe { JxlDecoderProcessInput(self.dec) };
 
             match status {
-                NeedMoreInput | Error => return Err(DecodeError::GenericError),
+                s::NeedMoreInput | s::Error => return Err(DecodeError::GenericError),
 
                 // Get the basic info
-                BasicInfo => {
+                s::BasicInfo => {
                     check_dec_status(unsafe {
                         JxlDecoderGetBasicInfo(self.dec, basic_info.as_mut_ptr())
                     })?;
@@ -238,12 +238,12 @@ impl<'pr, 'mm> JxlDecoder<'pr, 'mm> {
                 }
 
                 // Get color encoding
-                ColorEncoding => {
+                s::ColorEncoding => {
                     self.get_icc_profile(unsafe { icc.as_mut().unwrap_unchecked() })?;
                 }
 
                 // Get JPEG reconstruction buffer
-                JpegReconstruction => {
+                s::JpegReconstruction => {
                     // Safety: JpegReconstruction is only called when reconstruct_jpeg_buffer
                     // is not None
                     let buf = unsafe { reconstruct_jpeg_buffer.as_mut().unwrap_unchecked() };
@@ -254,7 +254,7 @@ impl<'pr, 'mm> JxlDecoder<'pr, 'mm> {
                 }
 
                 // JPEG buffer need more space
-                JpegNeedMoreOutput => {
+                s::JpegNeedMoreOutput => {
                     // Safety: JpegNeedMoreOutput is only called when reconstruct_jpeg_buffer
                     // is not None
                     let buf = unsafe { reconstruct_jpeg_buffer.as_mut().unwrap_unchecked() };
@@ -267,12 +267,12 @@ impl<'pr, 'mm> JxlDecoder<'pr, 'mm> {
                 }
 
                 // Get the output buffer
-                NeedImageOutBuffer => {
+                s::NeedImageOutBuffer => {
                     self.output(unsafe { &*basic_info.as_ptr() }, data_type, format, pixels)?;
                 }
 
-                FullImage => continue,
-                Success => {
+                s::FullImage => continue,
+                s::Success => {
                     if let Some(buf) = reconstruct_jpeg_buffer.as_mut() {
                         let remaining = unsafe { JxlDecoderReleaseJPEGBuffer(self.dec) };
 
@@ -296,13 +296,13 @@ impl<'pr, 'mm> JxlDecoder<'pr, 'mm> {
                         icc_profile: icc,
                     });
                 }
-                NeedPreviewOutBuffer => todo!(),
-                BoxNeedMoreOutput => todo!(),
-                Extensions => todo!(),
-                PreviewImage => todo!(),
-                Frame => todo!(),
-                Box => todo!(),
-                FrameProgression => todo!(),
+                s::NeedPreviewOutBuffer => todo!(),
+                s::BoxNeedMoreOutput => todo!(),
+                s::Extensions => todo!(),
+                s::PreviewImage => todo!(),
+                s::Frame => todo!(),
+                s::Box => todo!(),
+                s::FrameProgression => todo!(),
             }
         }
     }

jpegxl-rs/src/lib.rs

@@ -15,11 +15,6 @@ You should have received a copy of the GNU General Public License
 along with jpegxl-rs.  If not, see <https://www.gnu.org/licenses/>.
 */
 
-#![warn(missing_docs)]
-#![deny(clippy::all)]
-#![warn(clippy::pedantic)]
-#![allow(clippy::enum_glob_use)]
-
 //! [![Documentation](https://docs.rs/jpegxl-rs/badge.svg)](https://docs.rs/jpegxl-rs/)
 //! [![Crates.io](https://img.shields.io/crates/v/jpegxl-rs.svg)](https://crates.io/crates/jpegxl-rs)
 //! [![dependency status](https://deps.rs/repo/github/inflation/jpegxl-rs/status.svg)](https://deps.rs/repo/github/inflation/jpegxl-rs)

jpegxl-sys/Cargo.toml

@@ -13,6 +13,10 @@ version = "0.8.2+libjxl-0.8.2"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
+[lints.clippy]
+pedantic = "warn"
+module_name_repetitions = "allow"
+
 [package.metadata.docs.rs]
 features = ["docs"]
 

jpegxl-sys/build.rs

@@ -9,25 +9,25 @@ fn main() {
             .unwrap();
 
         if let Ok(path) = env::var("DEP_JXL_LIB") {
-            println!("cargo:rustc-link-search=native={}", path);
+            println!("cargo:rustc-link-search=native={path}");
             println!("cargo:rustc-link-lib=jxl");
             #[cfg(feature = "threads")]
             println!("cargo:rustc-link-lib=jxl_threads");
         } else {
             pkg_config::Config::new()
                 .atleast_version(version)
                 .probe("libjxl")
-                .unwrap_or_else(|_| panic!("Cannot find `libjxl` with version >= {}", version));
+                .unwrap_or_else(|_| panic!("Cannot find `libjxl` with version >= {version}"));
             #[cfg(feature = "threads")]
             pkg_config::Config::new()
                 .atleast_version(version)
                 .probe("libjxl_threads")
                 .unwrap_or_else(|_| {
-                    panic!("Cannot find `libjxl_threads` with version >= {}", version)
+                    panic!("Cannot find `libjxl_threads` with version >= {version}")
                 });
         }
     }
 
     #[cfg(feature = "vendored")]
-    jpegxl_src::build()
+    jpegxl_src::build();
 }

jpegxl-sys/src/lib.rs

@@ -15,8 +15,6 @@ You should have received a copy of the GNU General Public License
 along with jpegxl-sys.  If not, see <https://www.gnu.org/licenses/>.
 */
 
-#![warn(clippy::pedantic)]
-#![allow(clippy::module_name_repetitions)]
 #![cfg_attr(coverage_nightly, feature(coverage_attribute))]
 
 pub mod butteraugli;