Fix metadata encoding by setting JxlEncoderUseBoxes
#288
Annotations
2 errors and 1 warning
Run Clippy with reviewdog:
jpegxl-rs/src/encode.rs#L506
[clippy] reported by reviewdog 🐶
error: this function's return value is unnecessary
--> jpegxl-rs/src/encode.rs:506:5
|
506 | / fn test_usebox() -> TestResult {
507 | | let mut encoder = encoder_builder().build().unwrap();
508 | | encoder.add_metadata(&Metadata::Exif(&[0, 1, 2, 3]), true).unwrap();
509 | | assert!(encoder.use_box);
510 | | Ok(())
511 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_wraps
= note: `-D clippy::unnecessary-wraps` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_wraps)]`
help: remove the return type...
|
506 | fn test_usebox() -> TestResult {
| ~~~~~~~~~~
help: ...and then remove returned values
|
510 - Ok(())
510 +
|
Raw Output:
jpegxl-rs/src/encode.rs:506:5:e:error: this function's return value is unnecessary
--> jpegxl-rs/src/encode.rs:506:5
|
506 | / fn test_usebox() -> TestResult {
507 | | let mut encoder = encoder_builder().build().unwrap();
508 | | encoder.add_metadata(&Metadata::Exif(&[0, 1, 2, 3]), true).unwrap();
509 | | assert!(encoder.use_box);
510 | | Ok(())
511 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_wraps
= note: `-D clippy::unnecessary-wraps` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_wraps)]`
help: remove the return type...
|
506 | fn test_usebox() -> TestResult {
| ~~~~~~~~~~
help: ...and then remove returned values
|
510 - Ok(())
510 +
|
__END__
|
Run Clippy with reviewdog
reviewdog exited with status code: 1
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: giraffate/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Loading