Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable obfuscation #53

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Disable obfuscation #53

merged 2 commits into from
Mar 6, 2024

Conversation

KCeh
Copy link
Collaborator

@KCeh KCeh commented Mar 6, 2024

There is no point in obfuscating code for open source projects. It can only lead to harder issue debugging. This is why I removed it.
Notice that we are still using optimizations provided by R8 (I didn't disable it in build.gradle)

I will test if all is ok when publishing to the staging repo on Maven Central.

@KCeh KCeh requested review from antunflas and AsimRibo March 6, 2024 08:21
@KCeh KCeh self-assigned this Mar 6, 2024
@KCeh KCeh changed the base branch from master to develop March 6, 2024 08:21
@KCeh KCeh requested a review from bojankoma March 6, 2024 08:24
@KCeh
Copy link
Collaborator Author

KCeh commented Mar 6, 2024

Source https://stackoverflow.com/questions/51860843/how-to-turn-off-only-the-obfuscation-in-android-r8

JakeWharton: "You use ProGuard configurations for this, not a Gradle DSL. Disable shrinking with -dontshrink, disable obfuscation with -dontobfuscate, and disable optimization with -dontoptimize."

https://www.guardsquare.com/manual/configuration/usage

@KCeh KCeh merged commit 4b5123a into develop Mar 6, 2024
5 checks passed
@KCeh KCeh deleted the feature/disable-obfuscation branch March 6, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants