Prefetch event schedule data to improve initial load speed #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuayoes
commented
Apr 12, 2023
joshuayoes
commented
Apr 12, 2023
joshuayoes
commented
Apr 12, 2023
joshuayoes
commented
Apr 12, 2023
joshuayoes
commented
Apr 12, 2023
joshuayoes
force-pushed
the
queries-refactor
branch
from
e156b15 to
dfb2cee
Compare
joshuayoes
force-pushed
the
queries-refactor
branch
from
dfb2cee to
28c6bea
Compare
mazenchami
reviewed
Apr 21, 2023
There was a problem hiding this comment.
this is a really cool refactor and i think would help us potentially solve #153?
joshuayoes
force-pushed
the
queries-refactor
branch
from
bbda72c to
1127ca1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trello Card
One of the benefits of React Query is that we can have patterns like pre-populating a query cache so it seems like a transition is "instant".
This PR separates out
queryKeysandqueryFnsfrom hooks so that we can prefetch the event schedule queries on the initial welcome screen. That way, when the user clicks to the event schedule, it feels instantaneous because the data has already been fetched.This PR also updates Prettier because the existing version had an issue parsing the
satisifiesTypeScript keyword.yarn formatwas also run which updated a few unrelated screens.Graphics
The webflow network request in "Before" occur only once the user navigates to the event schedule screen. Whereas the network requests in "After" occur as soon as the app loads.
Screen.Recording.2023-04-11.at.8.25.52.PM.mov
Screen.Recording.2023-04-11.at.8.32.26.PM.mov
Checklist: